Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge arraylias integration branch into main #320

Merged
merged 14 commits into from
Feb 20, 2024
Merged

Merge arraylias integration branch into main #320

merged 14 commits into from
Feb 20, 2024

Conversation

DanPuzzuoli
Copy link
Collaborator

@DanPuzzuoli DanPuzzuoli commented Feb 8, 2024 •
edited
Loading

Summary

I believe all tests, linting, and docs should build.

Details and comments

Note: We should try to rebase and merge here, to preserve the history of the feature branch.

to24toro and others added 13 commits February 5, 2024 14:35
@to24toro @DanPuzzuoli
Update rotating_frame to use arraylias (#290)
5a4dd8b 
Co-authored-by: Daniel Puzzuoli <[email protected]>
@DanPuzzuoli @to24toro
Operator collections arraylias integration (#291)
6215f5a 
Co-authored-by: Kento Ueda <[email protected]>
@DanPuzzuoli @to24toro
Update model classes to use arraylias (#294)
1021036 
Co-authored-by: Kento Ueda <[email protected]>
@DanPuzzuoli
RWA arraylias conversion (#296)
8e5d884
@DanPuzzuoli @to24toro
Updating solvers module to use arraylias (#281)
5558ed6 
Co-authored-by: Kento Ueda <[email protected]>
@DanPuzzuoli
Update perturbation module to use arraylias (#299)
48d1c80
@DanPuzzuoli
fixing broken Array code that was rebased from main (#310)
ea2f607
@DanPuzzuoli
Update backend module to use arraylias (#311)
942cbb1
@DanPuzzuoli
Add release note for DynamicsBackend.from_backend signature change (#318
a0a262f 
)
@DanPuzzuoli @to24toro
Convert type_utils.py to use arraylias (#316)
d7a28d8 
Co-authored-by: Kento Ueda <[email protected]>
@to24toro @DanPuzzuoli
Replace dispatch'srequires_backend function for arraylias integration (…
e080487 
…#317)

Co-authored-by: Daniel Puzzuoli <[email protected]>
@DanPuzzuoli
getting docs to build (#319)
4d4c2b7
@DanPuzzuoli
Add Python 3.12 and drop 3.8 (#322)
f29573f
@DanPuzzuoli DanPuzzuoli force-pushed the arraylias-integration-branch branch from 49c4429 to 2351c20 Compare February 14, 2024 20:37
@DanPuzzuoli
Fixing issues with JAX type hints when not installed (#323)
acc2d45 
add _isArrayLike function for ArrayLike type checking in 3.9 (#325)
moving jax test
fixing linting
@DanPuzzuoli DanPuzzuoli force-pushed the arraylias-integration-branch branch from 2351c20 to acc2d45 Compare February 14, 2024 23:59
@DanPuzzuoli DanPuzzuoli requested a review from to24toro February 15, 2024 00:22
@to24toro
Copy link
Contributor

I feel that we need to update the docs about class Array, e.g. https://github.com/Qiskit-Extensions/qiskit-dynamics/pull/320/files#diff-5825e560f6952b8d63e201d90d8f56863d1742b76d8d87ce5e010a1aeae7a31aR25-R29 .

Is this the scope of the next PR?

to24toro
to24toro approved these changes Feb 18, 2024
View reviewed changes
Copy link
Contributor

@to24toro to24toro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DanPuzzuoli DanPuzzuoli merged commit 2b7d237 into main Feb 20, 2024
16 checks passed
@DanPuzzuoli DanPuzzuoli mentioned this pull request Feb 20, 2024
Closed
@DanPuzzuoli DanPuzzuoli deleted the arraylias-integration-branch branch March 6, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@to24toro to24toro to24toro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanPuzzuoli @to24toro