-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert type_utils.py to use arraylias #316
Merged
DanPuzzuoli
merged 17 commits into
qiskit-community:arraylias-integration-branch
from
DanPuzzuoli:type-utils-arraylias
Feb 8, 2024
Merged
Convert type_utils.py to use arraylias #316
DanPuzzuoli
merged 17 commits into
qiskit-community:arraylias-integration-branch
from
DanPuzzuoli:type-utils-arraylias
Feb 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e0947f
to
a0a262f
Compare
326ad61
to
7374235
Compare
to24toro
suggested changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I think the code becomes now very sophisticated.
I only request a great minor change.
Co-authored-by: Kento Ueda <[email protected]>
Co-authored-by: Kento Ueda <[email protected]>
Co-authored-by: Kento Ueda <[email protected]>
to24toro
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM!
d7a28d8
into
qiskit-community:arraylias-integration-branch
2 checks passed
DanPuzzuoli
added a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: Kento Ueda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR deletes
type_utils.py
; most functionality is no longer needed, and the two functions that were kept are moved tomodels/models_utils.py
.Details and comments
Details of what happened to the contents of
type_utils.py
:to_array
,to_csr
,to_BCOO
, andto_numeric_matrix_type
have been deleted, along with their tests.to_array
unnecessarily have been changed.ScipySparseVectorizedLindbladCollection
inoperator_collections.py
still had a final use ofto_csr
to remove. I modified the vectorized lindblad classes to no longer need this function, and ended up translating a test case forto_csr
handling of qutip Qobj types into a test case forunp.asarray
.StateTypeConverter
, along with its tests, have been completely deleted.solvers/scipy_solve_ivp.py
.solvers/scipy_solve_ivp.py
.vec_commutator
andvec_dissipator
, are only used inmodels/operator_collections.py
. As such I've movetype_utils.py
->models/models_utils.py
.Other changes:
test_jax_transformations.py
to no longer useArray
.csr_matrix
entries). When returned to a user, they used to return as a list ofcsr_matrix
entries, but now they just return thenumpy
object array. As such I've had to modify code in a few places that expect a list. These are very minor and sprinkled throughout the package.Test command (now we can just run all tests! :) ):
The whole repo should now also pass linting.