-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update model classes to use arraylias #294
Merged
DanPuzzuoli
merged 23 commits into
qiskit-community:models_arraylias_integration
from
DanPuzzuoli:generator-model-arraylias
Dec 14, 2023
Merged
Update model classes to use arraylias #294
DanPuzzuoli
merged 23 commits into
qiskit-community:models_arraylias_integration
from
DanPuzzuoli:generator-model-arraylias
Dec 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanPuzzuoli
changed the base branch from
main
to
models_arraylias_integration
December 8, 2023 20:15
to24toro
reviewed
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @DanPuzzuoli .
I added some minor change suggestions.
Co-authored-by: Kento Ueda <[email protected]>
Co-authored-by: Kento Ueda <[email protected]>
I've added a release note as well. |
to24toro
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
DanPuzzuoli
merged commit Dec 14, 2023
21f938e
into
qiskit-community:models_arraylias_integration
2 checks passed
DanPuzzuoli
added a commit
that referenced
this pull request
Jan 19, 2024
Co-authored-by: Kento Ueda <[email protected]>
DanPuzzuoli
added a commit
that referenced
this pull request
Jan 24, 2024
Co-authored-by: Kento Ueda <[email protected]>
DanPuzzuoli
added a commit
that referenced
this pull request
Feb 5, 2024
Co-authored-by: Kento Ueda <[email protected]>
DanPuzzuoli
added a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: Kento Ueda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the model classes to use arraylias.
Files to update:
generator_model.pytest_generator_model.pyhamiltonian_model.pytest_hamiltonian_model.pylindblad_model.pytest_lindblad_model.pyInterface changes:
copy
method has been removedsignals
andin_frame_basis
are being removed. I had wanted to make these classes fully immutable but the ability to set these two properties is used quite a bit throughout the solver infrastructure and I don't want to additionally make a change of this scale at this time. (In any case the main mutability issue had to do with the operators, so for now it's okay to keepsignals
andin_frame_basis
as mutable.)evaluation_mode
toarray_library
LindbladModel
, will also add a “vectorized” booleanarray_library=“scipy_sparse”
or"jax_sparse"
, a user MUST pass this asarray_library
.Other to do:
Details and comments
General notes:
HamiltonianModel
relies on the methodsGeneratorModel
, but the actual user-side behaviour has not changed (aside from the same changes made toGeneratorModel
).Test files that need to run before merge:
test.dynamics.models.test_lindblad_model
test.dynamics.models.test_hamiltonian_model
test.dynamics.models.test_generator_model
test.dynamics.models.rotating_frame
test.dynamics.models.operator_collections
test.dynamics.arraylias
(whole folder)