-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating solvers module to use arraylias #281
Updating solvers module to use arraylias #281
Conversation
8f6e46f
to
45473c3
Compare
f65437d
to
1c6c3ab
Compare
1c6c3ab
to
4eb6050
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @DanPuzzuoli .
I separated my PR comments from perturbation
updatePR.
Plese see if when you have time.
Co-authored-by: Kento Ueda <[email protected]>
Co-authored-by: Kento Ueda <[email protected]>
yes good catch - for now I don't want to fix documentation, I think it should all be fixed at the end when all of the changes have been made (to avoid having to make further unexpected changes). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for late approval.
4993e00
into
qiskit-community:arraylias-integration-branch
Co-authored-by: Kento Ueda <[email protected]>
Co-authored-by: Kento Ueda <[email protected]>
Co-authored-by: Kento Ueda <[email protected]>
Co-authored-by: Kento Ueda <[email protected]>
Summary
This PR updates all of the
solvers
folder to usearraylias
, aside from theperturbative_solvers
folder, which must be updated after theperturbation
folder.The new release notes describe the material change to the interface:
Solver.__init__
now takes argumentsarray_library
andvectorized
instead ofevaluation_mode
.Solver.solve
decides to automatically JAX compile when simulating a list of schedules has been slightly modified.Details and comments
All of the tests in the following command should be passing: