Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove seaborn.apionly compatibility #3749

Merged
merged 4 commits into from
Feb 5, 2020
Merged

remove seaborn.apionly compatibility #3749

merged 4 commits into from
Feb 5, 2020

Conversation

mathause
Copy link
Collaborator

@mathause mathause commented Feb 4, 2020

@mathause mathause requested a review from dcherian February 4, 2020 17:01
@mathause
Copy link
Collaborator Author

mathause commented Feb 4, 2020

I think the test failures are unrelated.

dcherian
dcherian approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mathause This is a nice cleanup

@keewis keewis merged commit 52ee5df into pydata:master Feb 5, 2020
@keewis
Copy link
Collaborator

keewis commented Feb 5, 2020

thanks, @mathause

@mathause mathause deleted the deprecate_seaborn_apionly_compat branch February 14, 2020 10:53
dcherian added a commit to johnomotani/xarray that referenced this pull request Feb 24, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into fix-contourf-set_…
103657d 
…under

* upstream/master: (71 commits)
  Optimize isel for lazy array equality checking (pydata#3588)
  pin msgpack (pydata#3793)
  concat now handles non-dim coordinates only present in one dataset (pydata#3769)
  Add new h5netcdf backend phony_dims kwarg (pydata#3753)
  always use dask_array_type for isinstance calls (pydata#3787)
  allow formatting the diff of ndarray attributes (pydata#3728)
  Pint support for variables (pydata#3706)
  Format issue template comment as md comment (pydata#3790)
  Avoid running test_open_mfdataset_list_attr without dask (pydata#3780)
  remove seaborn.apionly compatibility (pydata#3749)
  Python 3.8 CI (pydata#3727)
  PKG: Explicitly add setuptools dependency (pydata#3628)
  update whats-new
  Typo in Universal Functions section (pydata#3663)
  Release v0.15.0
  fix setup.cfg
  Documentation fixes (pydata#3732)
  Remove extra && in PR template (pydata#3730)
  Remove garbage text inserted in DASK_LICENSE (pydata#3729)
  Avoid unsafe use of pip (pydata#3726)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The seaborn.apionly entry-point has been removed.
3 participants
@mathause @keewis @dcherian