Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.8 CI #3727

Merged
merged 9 commits into from
Jan 31, 2020
Merged

Python 3.8 CI #3727

merged 9 commits into from
Jan 31, 2020

Conversation

crusaderky
Copy link
Contributor

@crusaderky crusaderky commented Jan 29, 2020

  • Run full-fat suite of tests for Python 3.8
  • Move asv, MacOSX tests, readthedocs, binder, and more to Python 3.8
  • Test windows against latest numpy version
  • Windows tests remain on Python 3.7 because of a couple of Python 3.8 tests that fail exclusively in CI. Will investigate later.

@crusaderky crusaderky closed this Jan 30, 2020
@crusaderky crusaderky reopened this Jan 30, 2020
@crusaderky
Copy link
Contributor Author

I have no clue whatsoever what's going on with docs?!? I didn't change it in any way and it's just... freezing?!?

@dcherian
Copy link
Contributor

There are some warnings:

[autosummary] generating autosummary for: README.rst, api-hidden.rst, api.rst, combining.rst, computation.rst, contributing.rst, dask.rst, data-structures.rst, examples.rst, examples/ERA5-GRIB-example.ipynb, ..., plotting.rst, quick-overview.rst, related-projects.rst, reshaping.rst, roadmap.rst, terminology.rst, time-series.rst, weather-climate.rst, whats-new.rst, why-xarray.rst
WARNING: [autosummary] failed to import 'xarray.CFTimeIndex.base': no module named xarray.CFTimeIndex.base
WARNING: [autosummary] failed to import 'xarray.CFTimeIndex.data': no module named xarray.CFTimeIndex.data
WARNING: [autosummary] failed to import 'xarray.CFTimeIndex.dtype_str': no module named xarray.CFTimeIndex.dtype_str
WARNING: [autosummary] failed to import 'xarray.CFTimeIndex.flags': no module named xarray.CFTimeIndex.flags
WARNING: [autosummary] failed to import 'xarray.CFTimeIndex.get_duplicates': no module named xarray.CFTimeIndex.get_duplicates
WARNING: [autosummary] failed to import 'xarray.CFTimeIndex.get_values': no module named xarray.CFTimeIndex.get_values
WARNING: [autosummary] failed to import 'xarray.CFTimeIndex.is_lexsorted_for_tuple': no module named xarray.CFTimeIndex.is_lexsorted_for_tuple
WARNING: [autosummary] failed to import 'xarray.CFTimeIndex.itemsize': no module named xarray.CFTimeIndex.itemsize
WARNING: [autosummary] failed to import 'xarray.CFTimeIndex.strides': no module named xarray.CFTimeIndex.strides
WARNING: [autosummary] failed to import 'xarray.CFTimeIndex.summary': no module named xarray.CFTimeIndex.summary

and an error?

Sphinx parallel build error:
RuntimeError: Non Expected warning in `/home/vsts/work/1/s/doc/dask.rst` line 136


>>>-------------------------------------------------------------------------
Warning in /home/vsts/work/1/s/doc/dask.rst at block ending on line 136
Specify :okwarning: as an option in the ipython:: block to suppress this message
----------------------------------------------------------------------------
/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/dask/dataframe/_compat.py:19: FutureWarning: pandas.util.testing is deprecated. Use the functions in the public API at pandas.testing instead.
  import pandas.util.testing as tm  # noqa: F401
<<<-------------------------------------------------------------------------

@keewis
Copy link
Collaborator

keewis commented Jan 30, 2020

Even if those were problems, the build should fail, not freeze. I think that's #3697, which freezes the build when trying to run ds.to_netcdf("manipulated-example-data.nc").

@keewis
Copy link
Collaborator

keewis commented Jan 30, 2020

the warning seems to be from dask.dataframe and I can't reproduce the autosummary warnings, which is probably because pandas removed those in 1.0.0

@crusaderky
Copy link
Contributor Author

Ready for review and merge.
TODO After merging in master:

  • check rtd build
  • check binder

@dcherian
Copy link
Contributor

Thanks @crusaderky .

Merging hoping that this may fix our RTD issues

@dcherian dcherian merged commit 4c96d53 into pydata:master Jan 31, 2020
dcherian added a commit to dcherian/xarray that referenced this pull request Jan 31, 2020
* upstream/master:
  Python 3.8 CI (pydata#3727)
  PKG: Explicitly add setuptools dependency (pydata#3628)
  update whats-new
  Typo in Universal Functions section (pydata#3663)
  Release v0.15.0
  fix setup.cfg
  Documentation fixes (pydata#3732)
  Remove extra && in PR template (pydata#3730)
  Remove garbage text inserted in DASK_LICENSE (pydata#3729)
  Avoid unsafe use of pip (pydata#3726)
  remove PR pre-black instructions (pydata#3707)
  Fix whats-new for 0.15 (pydata#3723)
  Add isort to CI (pydata#3721)
  setuptools-scm (3) (pydata#3724)
  Fix Sphinx links on contributing doc page (pydata#3710)
@crusaderky crusaderky deleted the py38 branch February 10, 2020 09:41
dcherian added a commit to johnomotani/xarray that referenced this pull request Feb 24, 2020
…under

* upstream/master: (71 commits)
  Optimize isel for lazy array equality checking (pydata#3588)
  pin msgpack (pydata#3793)
  concat now handles non-dim coordinates only present in one dataset (pydata#3769)
  Add new h5netcdf backend phony_dims kwarg (pydata#3753)
  always use dask_array_type for isinstance calls (pydata#3787)
  allow formatting the diff of ndarray attributes (pydata#3728)
  Pint support for variables (pydata#3706)
  Format issue template comment as md comment (pydata#3790)
  Avoid running test_open_mfdataset_list_attr without dask (pydata#3780)
  remove seaborn.apionly compatibility (pydata#3749)
  Python 3.8 CI (pydata#3727)
  PKG: Explicitly add setuptools dependency (pydata#3628)
  update whats-new
  Typo in Universal Functions section (pydata#3663)
  Release v0.15.0
  fix setup.cfg
  Documentation fixes (pydata#3732)
  Remove extra && in PR template (pydata#3730)
  Remove garbage text inserted in DASK_LICENSE (pydata#3729)
  Avoid unsafe use of pip (pydata#3726)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants