Add new h5netcdf backend phony_dims kwarg #3753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
reviewed
Feb 5, 2020
dcherian
changed the title
mathause
reviewed
Feb 5, 2020
kmuehlbauer
force-pushed
the
add_h5netcdf_backend_kwarg
branch
2 times, most recently
from
2028752 to
4c45c55
Compare
kmuehlbauer
force-pushed
the
add_h5netcdf_backend_kwarg
branch
from
4c45c55 to
ee0db0b
Compare
|
Changes added as suggested in the review comments. Sorry for excessive use of force-pushing. |
dcherian
reviewed
Feb 6, 2020
|
@dcherian This is ready for another review. Please let me know, if I can be of any further assistance. |
|
LGTM. I'll merge in a couple of days if no one else has any comments. |
|
Thanks @kmuehlbauer |
dcherian
added a commit
to johnomotani/xarray
that referenced
this pull request
Feb 24, 2020
…under * upstream/master: (71 commits) Optimize isel for lazy array equality checking (pydata#3588) pin msgpack (pydata#3793) concat now handles non-dim coordinates only present in one dataset (pydata#3769) Add new h5netcdf backend phony_dims kwarg (pydata#3753) always use dask_array_type for isinstance calls (pydata#3787) allow formatting the diff of ndarray attributes (pydata#3728) Pint support for variables (pydata#3706) Format issue template comment as md comment (pydata#3790) Avoid running test_open_mfdataset_list_attr without dask (pydata#3780) remove seaborn.apionly compatibility (pydata#3749) Python 3.8 CI (pydata#3727) PKG: Explicitly add setuptools dependency (pydata#3628) update whats-new Typo in Universal Functions section (pydata#3663) Release v0.15.0 fix setup.cfg Documentation fixes (pydata#3732) Remove extra && in PR template (pydata#3730) Remove garbage text inserted in DASK_LICENSE (pydata#3729) Avoid unsafe use of pip (pydata#3726) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the new
phony_dimskeyword for the h5netcdf backend which is available fromh5netcdfversion 0.8.0.isort -rc . && black . && mypy . && flake8whats-new.rstfor all changes andapi.rstfor new API