Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The seaborn.apionly entry-point has been removed. #3747

Closed
mathause opened this issue Feb 4, 2020 · 2 comments · Fixed by #3749
Closed

The seaborn.apionly entry-point has been removed. #3747

mathause opened this issue Feb 4, 2020 · 2 comments · Fixed by #3749

Comments

@mathause
Copy link
Collaborator

mathause commented Feb 4, 2020

Seaborn recently dropped the apionly entry point (in version 0.10.0).

There is a dedicated import_seaborn function

def import_seaborn():

but it is not used in one place

from seaborn.apionly import color_palette

which now causes test failures

https://dev.azure.com/xarray/xarray/_build/results?buildId=2111&view=ms.vss-test-web.build-test-results-tab&runId=29632&paneView=debug&resultId=108176

Todo: double check if the supported versions of seaborn still require this workaround.

@mathause mathause mentioned this issue Feb 4, 2020
3 tasks
@mathause
Copy link
Collaborator Author

mathause commented Feb 4, 2020

The apionly entrypoint has been deprecated in seaborn 0.8.0. The minimum seaborn requirement is currently 0.9.0:

So I think the def import_seaborn function can be dropped.

@dcherian
Copy link
Contributor

dcherian commented Feb 4, 2020

Thanks @mathause . Are you up for sending in a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants