Code

Issue 2418 dimensional#2419

Code

Merged

valentinsulzer merged 141 commits intodeveloppybamm-team/PyBaMM:developfrom issue-2418-dimensionalpybamm-team/PyBaMM:issue-2418-dimensionalCopy head branch name to clipboardMar 1, 2023

+4,988-7,278

Commits

Commits on Nov 1, 2022

• #2418 SPM builds but doesn't solve

  valentinsulzer

  committed
  3b18847

• #2418 DFN builds but can't solve

  valentinsulzer

  committed
  3c261c9

• #2418 SPMe builds but doesn't solve

  valentinsulzer

  committed
  bb2d595

Commits on Nov 2, 2022

• #2418 removing timescale and length scale

  valentinsulzer

  committed
  ce76821

• #2418 basic SPM works

  valentinsulzer

  committed
  a80e91c

• style: pre-commit fixes

  pre-commit-ci[bot]

  committed
  f2923a4

• #2418 working on basic models

  valentinsulzer

  committed
  00ca3f8

• Merge branch 'issue-2418-dimensional' of github.com:pybamm-team/PyBaMM into issue-2418-dimensional

  valentinsulzer

  committed
  37e7937

Commits on Nov 3, 2022

• #2418 working on flake8

  valentinsulzer

  committed
  59a42cf

Commits on Nov 4, 2022

• #2418 made SEI dimensional, some other random changes

  valentinsulzer

  committed
  563a5d5

Commits on Nov 5, 2022

• #2418 working on thermal and mechanical models

  valentinsulzer

  committed
  a55c522

Commits on Nov 6, 2022

• #2418 remove first-order lead-acid models

  valentinsulzer

  committed
  185f23d

• #2418 flake8 and remove lead-acid properly

  valentinsulzer

  committed
  0512766

• #2418 merge develop

  valentinsulzer

  committed
  4c6bbdf

• style: pre-commit fixes

  pre-commit-ci[bot]

  committed
  c564377

• #2418 remove C_rate parameter (set to 1)

  valentinsulzer

  committed
  f806319

• #2418 fixed SPM, fixed diffusion models

  valentinsulzer

  committed
  e5e84a5

• merge

  valentinsulzer

  committed
  349d5b4

• Merge branch 'issue-2418-dimensional' of github.com:pybamm-team/PyBaMM into issue-2418-dimensional

  valentinsulzer

  committed
  e54f638

Commits on Nov 7, 2022

• merge develop

  valentinsulzer

  committed
  6170a1d

Commits on Nov 8, 2022

• #2418 working on standard models

  valentinsulzer

  committed
  116393e

• style: pre-commit fixes

  pre-commit-ci[bot]

  committed
  c3c57c8

• debugging DFN

  valentinsulzer

  committed
  5deddaf

• Merge branch 'issue-2418-dimensional' of github.com:pybamm-team/PyBaMM into issue-2418-dimensional

  valentinsulzer

  committed
  5c7493e

• merge simplifications

  valentinsulzer

  committed
  ac84d10

• #2418 DFN now works (with reference potentials)

  valentinsulzer

  committed
  466131a

Commits on Nov 9, 2022

• merge

  valentinsulzer

  committed
  efdb914

• #2418 almost all SPM unit tests pass

  valentinsulzer

  committed
  6410607

• #2418 fix division by zero warning

  valentinsulzer

  committed
  e998ddd

• #2418 flake8

  valentinsulzer

  committed
  a880f9a

• working on polynomial particle model

  valentinsulzer

  committed
  3e07b17

• merge

  valentinsulzer

  committed
  e7b4c85

Commits on Nov 10, 2022

• merge

  valentinsulzer

  committed
  d16497d

• #2418 testing polynomial models

  valentinsulzer

  committed
  a99f2f7

Commits on Nov 14, 2022

• working on unit tests

  valentinsulzer

  committed
  e8abbc0

• #2418 working on tests

  valentinsulzer

  committed
  7ff854c

• #2418 tests

  valentinsulzer

  committed
  4857881

Commits on Nov 15, 2022

• #2418 working on tests

  valentinsulzer

  committed
  1038634

• #2418 fixing more tests

  valentinsulzer

  committed
  ba3453c

• style: pre-commit fixes

  pre-commit-ci[bot]

  committed
  91df22d

• Merge branch 'develop' into issue-2418-dimensional

  valentinsulzer

  committed
  1068788

• #2418 unit tests

  valentinsulzer

  committed
  c5b2e60

Commits on Nov 19, 2022

• #2418 merge develop

  valentinsulzer

  committed
  8d8d658

Commits on Nov 20, 2022

• #2418 fixing tests

  valentinsulzer

  committed
  ca8f3ad

Commits on Nov 22, 2022

• Merge branch 'develop' into issue-2418-dimensional

  valentinsulzer

  committed
  850d6b3

• #2418 skip external variables, will be removed

  valentinsulzer

  committed
  1cc64b0

Commits on Nov 26, 2022

• merge develop

  valentinsulzer

  committed
  678f854

• fix temp [C]

  valentinsulzer

  committed
  a287e6a

• #2418 debugging

  valentinsulzer

  committed
  11f3cbb

• #2418 merge 2491

  valentinsulzer

  committed
  95fe21e

• #2418 fixing tests, unit tests should finish now

  valentinsulzer

  committed
  ce4a6b3

• #2418 fixing tests

  valentinsulzer

  committed
  54b09e8

Commits on Nov 27, 2022

• Merge branch 'issue-2491-parameter-events' into issue-2418-dimensional

  valentinsulzer

  committed
  3bbd7a7

Commits on Nov 29, 2022

• Merge branch 'develop' into issue-2418-dimensional

  valentinsulzer

  committed
  68b8b72

• #2418 debugging

  valentinsulzer

  committed
  8a45e76

Commits on Nov 30, 2022

• Merge branch 'develop' into issue-2418-dimensional

  valentinsulzer

  committed
  808ae56

• #2418 unit tests

  valentinsulzer

  committed
  c94881d

• #2418 ecm parameters

  valentinsulzer

  committed
  352b6d1

• #2418 integration tests

  valentinsulzer

  committed
  dc3a9c2

• debugging

  valentinsulzer

  committed
  029d0b7

• #2418 better conditioning for algebraic equations

  valentinsulzer

  committed
  0cf71ad

• #2418 fix unit tests, add scaling to some algebraic equations

  valentinsulzer

  committed
  6a5489f

• #2418 fix unit tests

  valentinsulzer

  committed
  9359f7a

• #2418 lead-acid

  valentinsulzer

  committed
  0fe3a9d

Commits on Dec 5, 2022

• merge develop

  valentinsulzer

  committed
  fffbe96

• #2418 debugging

  valentinsulzer

  committed
  aaff9d6

Commits on Dec 6, 2022

• Merge branch 'develop' into issue-2418-dimensional

  valentinsulzer

  committed
  a0650a6

Commits on Dec 7, 2022

• fix SEI model

  valentinsulzer

  committed
  e0e7b54

• fix li plating

  valentinsulzer

  committed
  7c699b0

• #2418 fix cracking

  valentinsulzer

  committed
  a135113

Commits on Dec 11, 2022

• #2418 merge

  valentinsulzer

  committed
  0f9922d

Commits on Dec 12, 2022

• Merge branch 'porosity-times-concentration' into issue-2418-dimensional

  valentinsulzer

  committed
  9c2ad72

• flake8

  valentinsulzer

  committed
  22f5603

• #2418 flake8

  valentinsulzer

  committed
  cf00094

• merge

  valentinsulzer

  committed
  b50ac7e

• fix current driven utilization

  valentinsulzer

  committed
  85a72d3

• #2418 fix spm lam tests

  valentinsulzer

  committed
  ccc76ee

• use cumulative trapezoid

  valentinsulzer

  committed
  cf646a2

Commits on Dec 13, 2022

• debugging

  valentinsulzer

  committed
  01b810d

• #2418 debugging

  valentinsulzer

  committed
  8714c0f

• remove skips to avoid conflicts

  valentinsulzer

  committed
  a0fbd0a

• #2418 merge external variable removal

  valentinsulzer

  committed
  173027c

• loosen tol for split electrlyte concentration test

  valentinsulzer

  committed
  99494c8

• #2418 fix electrolyte and thermal tests

  valentinsulzer

  committed
  24c9655

• working on newman-tobias

  valentinsulzer

  committed
  b867532

• NT

  valentinsulzer

  committed
  4e015f1

• debugging NT

  valentinsulzer

  committed
  ececf95

Commits on Dec 14, 2022

• merge

  valentinsulzer

  committed
  d43c152

• merge changes, still note conserving lithium

  valentinsulzer

  committed
  17f2f5c

• Merge branch 'issue-2551-electrolyte' into issue-2418-dimensional

  valentinsulzer

  committed
  ec07855

• debugging lead-acid

  valentinsulzer

  committed
  8d0657e

Commits on Dec 15, 2022

• #2418 fix lead-acid tests

  valentinsulzer

  committed
  2ae1bf5

• #2418 flake8

  valentinsulzer

  committed
  01d1c23

Commits on Jan 9, 2023

• merge develop

  valentinsulzer

  committed
  d2f5d2c

• Merge branch 'develop' into issue-2418-dimensional

  valentinsulzer

  committed
  5d6d5c0

Commits on Jan 26, 2023

• merge contact resistance update

  valentinsulzer

  committed
  5ae4ef2

• #2418 fix contact resistance test and spectral volume test

  valentinsulzer

  committed
  1baf01f

Commits on Feb 17, 2023

• merge develop

  valentinsulzer

  committed
  603f79f

• style: pre-commit fixes

  pre-commit-ci[bot]

  committed
  7ff5563

• fix BV test

  valentinsulzer

  committed
  c6fd9c1

• fix some DFN tests

  valentinsulzer

  committed
  87d441e

• merge develop

  valentinsulzer

  committed
  9d6d7d3

• Merge branch 'issue-2418-dimensional' of github.com:pybamm-team/PyBaMM into issue-2418-dimensional

  valentinsulzer

  committed
  fc606ec

• fix unit test

  valentinsulzer

  committed
  bdcd75a

• merge develop

  valentinsulzer

  committed
  338be72

• Merge branch 'develop' into issue-2418-dimensional

  valentinsulzer

  committed
  d9a88c6

Commits on Feb 18, 2023

• fix output comparison test

  valentinsulzer

  committed
  48d5044

• quartic profile

  valentinsulzer

  committed
  f4072f2

• changelog

  valentinsulzer

  committed
  7803bf3

• fix half-cell bug

  valentinsulzer

  committed
  5302e86

• integration tests

  valentinsulzer

  committed
  21c8e4c

• half-cell test

  valentinsulzer

  committed
  e337e62

• updating docs

  valentinsulzer

  committed
  5fdee96

• style

  valentinsulzer

  committed
  50b41f9

• coverage

  valentinsulzer

  committed
  07f1f57

• coverage - parameters

  valentinsulzer

  committed
  72f8688

• more coverage

  valentinsulzer

  committed
  db705a3

• scikit fem coverage

  valentinsulzer

  committed
  917ed6f

• tests and coverage

  valentinsulzer

  committed
  ae30a97

Commits on Feb 19, 2023

• working on examples

  valentinsulzer

  committed
  908395a

• Merge branch 'issue-2703-temperature' into issue-2418-dimensional

  valentinsulzer

  committed
  b1f1742

• fix plating example

  valentinsulzer

  committed
  c8416cc

• Merge branch 'develop' into issue-2418-dimensional

  valentinsulzer

  committed
  85ea886

• working on examples

  valentinsulzer

  committed
  c21cdfb

• remove typical electrolyte concentration and fix tests

  valentinsulzer

  committed
  c1780c6

• fix lead-acid tests

  valentinsulzer

  committed
  9dfe43a

• #2418 fix electrolyte concentration

  valentinsulzer

  committed
  b92ba78

• Merge branch 'develop' into issue-2418-dimensional

  valentinsulzer

  committed
  314cb12

• cracking model

  valentinsulzer

  committed
  5337210

• tests and urls

  valentinsulzer

  committed
  72351b3

Commits on Feb 20, 2023

• latexify

  valentinsulzer

  committed
  ee69970

• fix examples

  valentinsulzer

  committed
  3708a08

• another fix attempt

  valentinsulzer

  committed
  b99b0fc

Commits on Feb 21, 2023

• rob comments

  valentinsulzer

  committed
  73b2a3c

Commits on Feb 22, 2023

• Merge branch 'issue-2418-dimensional' of https://github.com/pybamm-team/PyBaMM into issue-2418-dimensional

  

  DrSOKane

  committed
  d7ed340

Commits on Feb 23, 2023

• Divided dl_cr by 3600 to replace deleted constant t0_cr

  

  DrSOKane

  committed
  339b745

• Merge pull request #2724 from DrSOKane/issue-2418-dimensional

  Show description for eb492fc
  valentinsulzer

  authored
  eb492fc

• #2418 merge develop

  valentinsulzer

  committed
  9ff550f

• Update pybamm/CITATIONS.txt

  Show description for dc71db2
  

  valentinsulzer

  and

  brosaplanella

  authored
  dc71db2

Commits on Feb 28, 2023

• Merge branch 'develop' into issue-2418-dimensional

  valentinsulzer

  committed
  0483f46

• #2418 changelog

  valentinsulzer

  committed
  5816493