Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divided by 3600 to replace t0_cr #2724

Conversation

DrSOKane
Copy link
Contributor

Description

The old non-dimensionalized PyBaMM had a constant t0_cr used for the crack propagation submodel. This was deleted, so I divided dl_cr/dt by 3600 (standard value for t0_cr) to compensate and retreive the same results as existing PyBaMM.

Fixes #2418

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks very much

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 99.68% // Head: 99.68% // No change to project coverage 👍

Coverage data is based on head (339b745) compared to base (73b2a3c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           issue-2418-dimensional    #2724   +/-   ##
=======================================================
  Coverage                   99.68%   99.68%           
=======================================================
  Files                         270      270           
  Lines                       18945    18945           
=======================================================
  Hits                        18886    18886           
  Misses                         59       59           
Impacted Files Coverage Δ
.../submodels/particle_mechanics/crack_propagation.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@valentinsulzer valentinsulzer merged commit eb492fc into pybamm-team:issue-2418-dimensional Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants