-
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Divided by 3600 to replace t0_cr #2724
Divided by 3600 to replace t0_cr #2724
Conversation
updates: - [github.com/charliermarsh/ruff-pre-commit: v0.0.246 → v0.0.249](astral-sh/ruff-pre-commit@v0.0.246...v0.0.249)
…date-config chore: update pre-commit hooks
Multi-cycle addition to composite electrode notebook
…/add-BradyPlanden docs: add BradyPlanden as a contributor for example
…rature pybamm-team#2703 remove warning if temperature not provided
…am/PyBaMM into issue-2418-dimensional
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks very much
Codecov ReportBase: 99.68% // Head: 99.68% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## issue-2418-dimensional #2724 +/- ##
=======================================================
Coverage 99.68% 99.68%
=======================================================
Files 270 270
Lines 18945 18945
=======================================================
Hits 18886 18886
Misses 59 59
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Description
The old non-dimensionalized PyBaMM had a constant t0_cr used for the crack propagation submodel. This was deleted, so I divided dl_cr/dt by 3600 (standard value for t0_cr) to compensate and retreive the same results as existing PyBaMM.
Fixes #2418
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
$ python run-tests.py --doctest
You can run unit and doctests together at once, using
$ python run-tests.py --quick
.Further checks: