Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2703 remove warning if temperature not provided #2704

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

valentinsulzer
Copy link
Member

Description

Fixes #2703

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Base: 99.69% // Head: 99.69% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (889f929) compared to base (f7e7a6f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2704      +/-   ##
===========================================
- Coverage    99.69%   99.69%   -0.01%     
===========================================
  Files          271      271              
  Lines        19620    19616       -4     
===========================================
- Hits         19560    19556       -4     
  Misses          60       60              
Impacted Files Coverage Δ
pybamm/meshes/one_dimensional_submeshes.py 100.00% <ø> (ø)
pybamm/experiments/experiment.py 100.00% <100.00%> (ø)
pybamm/solvers/idaklu_solver.py 99.07% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is annoying haha

@valentinsulzer valentinsulzer merged commit 4f03df4 into develop Feb 22, 2023
@valentinsulzer valentinsulzer deleted the issue-2703-temperature branch February 22, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove warning if temperature not in experiment step
2 participants