Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dimensional models #2418

Closed
valentinsulzer opened this issue Nov 1, 2022 · 3 comments · Fixed by #2419
Closed

Dimensional models #2418

valentinsulzer opened this issue Nov 1, 2022 · 3 comments · Fixed by #2419
Labels
difficulty: hard Will take several weeks

Comments

@valentinsulzer
Copy link
Member

Some basic profiling reveals that implementing the models in a dimensional way provides no slow-down compared to dimensionless. Since dimensionless models are a big barrier to entry, we should reformat the models to be entirely dimensional. Further benchmarking and testing will be needed.

Note: scaling variables is still a good idea for the condition number of the solver, but this can be done directly in the solver
@valentinsulzer
Copy link
Member Author

We currently have a lot of duplicate variables (dimensionless/dimensional).
Q: Should we just get rid of the dimensionless ones?

@valentinsulzer
Copy link
Member Author

Would be good to revive #406 when implementing this to add an additional layer of testing

valentinsulzer added a commit that referenced this issue Nov 1, 2022
@valentinsulzer
#2418 SPM builds but doesn't solve
3b18847
valentinsulzer added a commit that referenced this issue Nov 2, 2022
@valentinsulzer
#2418 DFN builds but can't solve
3c261c9
valentinsulzer added a commit that referenced this issue Nov 2, 2022
@valentinsulzer
#2418 SPMe builds but doesn't solve
bb2d595
valentinsulzer added a commit that referenced this issue Nov 2, 2022
@valentinsulzer
#2418 removing timescale and length scale
ce76821
valentinsulzer added a commit that referenced this issue Nov 2, 2022
@valentinsulzer
#2418 basic SPM works
a80e91c
@valentinsulzer valentinsulzer mentioned this issue Nov 2, 2022
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Nov 2, 2022
@valentinsulzer
#2418 working on basic models
00ca3f8
@brosaplanella
Copy link
Member

We currently have a lot of duplicate variables (dimensionless/dimensional). Q: Should we just get rid of the dimensionless ones?

I think so, I would just keep those that have actually some sort of physical meaning beyond being the dimensionless form of something (e.g. dimensionless particle concentrations / stoichiometry).

valentinsulzer added a commit that referenced this issue Nov 3, 2022
@valentinsulzer
#2418 working on scales
66cb32d
valentinsulzer added a commit that referenced this issue Nov 3, 2022
@valentinsulzer
#2418 working on flake8
59a42cf
valentinsulzer added a commit that referenced this issue Nov 4, 2022
@valentinsulzer
#2418 made SEI dimensional, some other random changes
563a5d5
valentinsulzer added a commit that referenced this issue Nov 5, 2022
@valentinsulzer
#2418 working on thermal and mechanical models
a55c522
valentinsulzer added a commit that referenced this issue Nov 6, 2022
@valentinsulzer
#2418 remove first-order lead-acid models
185f23d
valentinsulzer added a commit that referenced this issue Nov 6, 2022
@valentinsulzer
#2418 flake8 and remove lead-acid properly
0512766
valentinsulzer added a commit that referenced this issue Nov 6, 2022
@valentinsulzer
#2418 merge develop
4c6bbdf
valentinsulzer added a commit that referenced this issue Nov 6, 2022
@valentinsulzer
#2418 remove C_rate parameter (set to 1)
f806319
valentinsulzer added a commit that referenced this issue Nov 6, 2022
@valentinsulzer
#2418 fixed SPM, fixed diffusion models
e5e84a5
valentinsulzer added a commit that referenced this issue Nov 8, 2022
@valentinsulzer
#2418 working on standard models
116393e
@valentinsulzer valentinsulzer mentioned this issue Nov 9, 2022
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Nov 9, 2022
@valentinsulzer
#2418 DFN now works (with reference potentials)
466131a
valentinsulzer added a commit that referenced this issue Nov 9, 2022
@valentinsulzer
#2418 almost all SPM unit tests pass
6410607
valentinsulzer added a commit that referenced this issue Nov 9, 2022
@valentinsulzer
#2418 fix division by zero warning
e998ddd
valentinsulzer added a commit that referenced this issue Nov 9, 2022
@valentinsulzer
#2418 flake8
a880f9a
valentinsulzer added a commit that referenced this issue Nov 10, 2022
@valentinsulzer
#2418 testing polynomial models
a99f2f7
valentinsulzer added a commit that referenced this issue Nov 14, 2022
@valentinsulzer
#2418 working on tests
7ff854c
valentinsulzer added a commit that referenced this issue Nov 14, 2022
@valentinsulzer
#2418 tests
4857881
valentinsulzer added a commit that referenced this issue Nov 15, 2022
@valentinsulzer
#2418 working on tests
1038634
valentinsulzer added a commit that referenced this issue Nov 15, 2022
@valentinsulzer
#2418 fixing more tests
ba3453c
valentinsulzer added a commit that referenced this issue Nov 22, 2022
@valentinsulzer
#2418 fixing tests
ca8f3ad
valentinsulzer added a commit that referenced this issue Nov 22, 2022
@valentinsulzer
#2418 skip external variables, will be removed
1cc64b0
valentinsulzer added a commit that referenced this issue Nov 26, 2022
@valentinsulzer
#2418 debugging
11f3cbb
valentinsulzer added a commit that referenced this issue Nov 26, 2022
@valentinsulzer
#2418 merge 2491
95fe21e
valentinsulzer added a commit that referenced this issue Nov 26, 2022
@valentinsulzer
#2418 fixing tests, unit tests should finish now
ce4a6b3
valentinsulzer added a commit that referenced this issue Nov 27, 2022
@valentinsulzer
#2418 fixing tests
54b09e8
valentinsulzer added a commit that referenced this issue Nov 30, 2022
@valentinsulzer
#2418 debugging
8a45e76
valentinsulzer added a commit that referenced this issue Nov 30, 2022
@valentinsulzer
#2418 unit tests
c94881d
valentinsulzer added a commit that referenced this issue Nov 30, 2022
@valentinsulzer
#2418 ecm parameters
352b6d1
valentinsulzer added a commit that referenced this issue Nov 30, 2022
@valentinsulzer
#2418 integration tests
dc3a9c2
valentinsulzer added a commit that referenced this issue Nov 30, 2022
@valentinsulzer
#2418 better conditioning for algebraic equations
0cf71ad
valentinsulzer added a commit that referenced this issue Nov 30, 2022
@valentinsulzer
#2418 fix unit tests, add scaling to some algebraic equations
6a5489f
valentinsulzer added a commit that referenced this issue Nov 30, 2022
@valentinsulzer
#2418 fix unit tests
9359f7a
valentinsulzer added a commit that referenced this issue Nov 30, 2022
@valentinsulzer
#2418 lead-acid
0fe3a9d
valentinsulzer added a commit that referenced this issue Dec 12, 2022
@valentinsulzer
#2418 debugging
aaff9d6
valentinsulzer added a commit that referenced this issue Dec 12, 2022
@valentinsulzer
#2418 fix cracking
a135113
valentinsulzer added a commit that referenced this issue Dec 12, 2022
@valentinsulzer
#2418 merge
0f9922d
valentinsulzer added a commit that referenced this issue Dec 12, 2022
@valentinsulzer
#2418 flake8
cf00094
valentinsulzer added a commit that referenced this issue Dec 13, 2022
@valentinsulzer
#2418 fix spm lam tests
ccc76ee
valentinsulzer added a commit that referenced this issue Dec 13, 2022
@valentinsulzer
#2418 debugging
8714c0f
valentinsulzer added a commit that referenced this issue Dec 13, 2022
@valentinsulzer
#2418 merge external variable removal
173027c
valentinsulzer added a commit that referenced this issue Dec 15, 2022
@valentinsulzer
#2418 fix electrolyte and thermal tests
24c9655
valentinsulzer added a commit that referenced this issue Dec 15, 2022
@valentinsulzer
#2418 fix lead-acid tests
2ae1bf5
valentinsulzer added a commit that referenced this issue Dec 15, 2022
@valentinsulzer
#2418 flake8
01d1c23
valentinsulzer added a commit that referenced this issue Jan 26, 2023
@valentinsulzer
#2418 fix contact resistance test and spectral volume test
1baf01f
valentinsulzer added a commit that referenced this issue Feb 19, 2023
@valentinsulzer
#2418 fix electrolyte concentration
b92ba78
@DrSOKane DrSOKane mentioned this issue Feb 23, 2023
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Feb 23, 2023
@valentinsulzer
#2418 merge develop
9ff550f
valentinsulzer added a commit that referenced this issue Feb 28, 2023
@valentinsulzer
#2418 changelog
5816493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: hard Will take several weeks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 2418 dimensional pybamm-team/PyBaMM
2 participants
@valentinsulzer @brosaplanella