Issue 2418 dimensional #2419
Merged
Issue 2418 dimensional #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…M into issue-2418-dimensional
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…M into issue-2418-dimensional
…M into issue-2418-dimensional
rtimms
requested changes
Feb 20, 2023
pybamm/models/full_battery_models/lithium_ion/basic_dfn_composite.py
Outdated
Show resolved
Hide resolved
tests/integration/test_models/test_full_battery_models/test_lithium_ion/test_compare_outputs.py
Outdated
Show resolved
Hide resolved
…am/PyBaMM into issue-2418-dimensional
Divided by 3600 to replace t0_cr
brosaplanella
approved these changes
Feb 23, 2023
| ] | ||
|
|
||
| self.algebraic[delta_phi] = sum_a_j_av - sum_a_j | ||
| self.algebraic[delta_phi] = (sum_a_j_av - sum_a_j) / self.param.a_j_scale |
There was a problem hiding this comment.
Is dividing by self.param.a_j_scale just to have a better conditioned problem?
| @@ -297,16 +277,17 @@ def _get_standard_volumetric_current_density_variables(self, variables): | |||
| phase_name = self.phase_name | |||
|
|
|||
| if isinstance(self, pybamm.kinetics.NoReaction): | |||
| a = 1 | |||
There was a problem hiding this comment.
Was this a bug or was it changed later one?(Asking because we have an issue with calendar ageing that could be related).
There was a problem hiding this comment.
for NoReaction it should have no effect on results since j=0 and a only ever appears as a * j
Co-authored-by: Ferran Brosa Planella <[email protected]>
rtimms
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes all models dimensional. Major changes:
scaleandreferenceattributes for variables, which can be set to make sure that variables are order 1. Algebraic equations also have to be multiplied by an appropriate number (e.g.L_x**2) to make them order 1 and hence pass the tolerance check.Most models are now a lot faster but some of the degradation models might be a bit slower, possibly less robust.
Fixes #2418
Fixes #2281
Fixes #2690
Fixes #1260
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: