This repository was archived by the owner on Mar 13, 2021. It is now read-only.
For in-cluster builds, use RUN_IMAGE from build template #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... rather than hard-coded default Fixes projectriff#1081
|
Isn't that going to break PFS? |
Not really. It would only break PFS if in-cluster builds didn't work with the build template, but then the user could edit the build template |
|
How do we pass the relocated image value now then? |
|
For in-cluster builds, the relocated image value should come from the build template. |
|
The build template uses a BuildTemplate variable. How does that variable gets its value is my point. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... rather than hard-coded default
Fixes #1081