Skip to content
This repository was archived by the owner on Mar 13, 2021. It is now read-only.

For in-cluster builds, use RUN_IMAGE from build template #1082

Merged
merged 1 commit into from
Jan 28, 2019
Merged

For in-cluster builds, use RUN_IMAGE from build template #1082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions pkg/core/function.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,6 @@ func (c *client) makeBuildArguments(options CreateFunctionOptions) []build.Argum
// TODO configure buildtemplate based on buildpack image
// {Name: "TBD", Value: options.BuildpackImage},
}
if options.RunImage != "" {
// don't overwrite the default with an empty value
args = append(args, build.ArgumentSpec{Name: "RUN_IMAGE", Value: options.RunImage})
}
return args
}

Expand Down