[DNM] Prevent RUN_IMAGE from being overridden in build template #22
Conversation
|
No, because the image detection scanner only looks for images in specific contexts and with specific clues. In general, image ids are hard to spot (e.g. "ubuntu") without other clues. |
|
So we need to wait for an update to that before merging this, I assume |
Yes. However, I'm not going to implement the scanner change just yet in case we throw out this PR. Once this PR is approved, I'll beef up the scanner and then merge this PR. Until the scanner is beefed up, I'll keep |
|
Eric approves :) |
There was a problem hiding this comment.
I don't think we should merge this, I'd actually like to go the opposite direction and add the builder images as a param. riff generally should not set these params, but they are still useful as params.
- it's easier to update the image values as there is only one spot
- it's easier for tools to lookup the image value
The builder template is used twice within the build template, as is the util image. We can centralize the definition of the builder image by using a parameter. In general, builds should not override the run or builder image params. It is still useful to parameterize them in order to make it easier for tooling to discover or update the value cluster wide. Refs projectriff#22
|
@glyn @ericbottard I opened #23 which runs in the opposite direction of this PR by also parameterizing the run and util images. |
|
I'm comfortable keeping the parameterisation. |
The build template parameter
RUN_IMAGEno longer needs to be overrideable now that PR projectriff/riff#1082 is merged. This PR makes sure the default value cannot be overridden.Downsides of this PR are:
Ref projectriff/riff#1081