Skip to content
This repository has been archived by the owner on Mar 13, 2021. It is now read-only.

For in-cluster builds, use RUN_IMAGE from build template rather than hard-coded default #1081

Closed
glyn opened this issue Jan 28, 2019 · 0 comments
Closed

For in-cluster builds, use RUN_IMAGE from build template rather than hard-coded default #1081

glyn opened this issue Jan 28, 2019 · 0 comments
Assignees
@glyn
Labels
riff-cli

Comments

@glyn
Copy link
Contributor

glyn commented Jan 28, 2019

When riff does an in-cluster build, it overrides the value of RUN_IMAGE in the build template (typically packs/run) with a hard-coded value (packs/run:v3alpha2 at the time of writing).

This prevents a user from configuring a different value in the build template.

It should use the value in the build template instead.
@glyn glyn added the riff-cli label Jan 28, 2019
@glyn glyn self-assigned this Jan 28, 2019
glyn added a commit to glyn/riff that referenced this issue Jan 28, 2019
@glyn
For in-cluster builds, use RUN_IMAGE from build template
3b1bbfd 
... rather than hard-coded default

Fixes projectriff#1081
@glyn glyn mentioned this issue Jan 28, 2019
Merged
scothis pushed a commit that referenced this issue Jan 28, 2019
@glyn @scothis
For in-cluster builds, use RUN_IMAGE from build template (#1082)
e0d765f 
... rather than hard-coded default

Fixes #1081
glyn added a commit to glyn/riff-buildpack-group that referenced this issue Jan 29, 2019
@glyn
Prevent RUN_IMAGE from being overridden in build template
a3e7d21 
Ref projectriff/riff#1081
@glyn glyn mentioned this issue Jan 29, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@glyn glyn

Labels
riff-cli
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glyn @scothis