This repository has been archived by the owner on Jan 19, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 70
atomicapp1 #804
Open
ieocampo
wants to merge
334
commits into
oc-new-app-with-nested-nulecules
Choose a base branch
from
master
base: oc-new-app-with-nested-nulecules
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
atomicapp1 #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new logging structure. Fix cockpit.
Remove extra whitespaces from logging output.
Fail if unable to find artifact
Change order of getting context
Update readme
Previously where the filename would have been 'main.py' in the log messages, it would now be 'cli/main.py' for verbose mode.
0.4.3 Release
In a clean environment where nothing is installed and if I run `make test` then the required modules should be installed first. So before `make test` added pip install from requirements.txt and test-requirements.txt. Fixes issue #574
When provider name in answers.conf is wrong then AtomicApp fails with stack-trace and no error output which is user understandable. This happened because there was no check for the condition if given provider_key does not match with any of the providers that are supported for now. Fixes Issue #562.
Doc for current functions implemented by spec
Fix minor markdown error in spec_coverage
Install requirements before make test
logging: add more context to filename in verbose mode
Wrong provider name in answers.conf, exits AtomicApp with readable error
This commit checks to see if the actual Nulecule exists before loading. If the Nulecule file is missing it will cleanly error out. If a Nulecule is wrongly formatted, atomicapp will exit cleanly with a line number, column and the output of the invalid line. ex. ``` 2016-03-04 13:03:59,617 - [ERROR] - main.py - Failure parsing Nulecule file. Validation error on line 12, column 23: { ``` Fixes issues: #581 #553
[EPIC] Major update to README and documentation
For the past two weeks, issuestats have been having multiple problems with uptime as well as API calls. (even right now at this moment: 03/07/2016 18:13 UTC each page load is more than 3000ms. Do we still want these on our README?
Multiple problems with issuestats.com
Fixing the build_run.sh Dockerfile path
This commit converts the current OpenShift provider to use the 'KubeShift' library. Allowing OpenShift to use the universal library for both Kubernetes and OpenShift, decreasing technical debt in learning how each provider API communicates. Tests are also added which cover a large majority of test scenarios for the KubeShift library. Included is a new pytest plugin which allows mocking an example HTTP server.
OpenShift to KubeShift
This bash script goes step-by-step on how to release a new version of Atomic App for both the main Github repo as well as the nulecule-library.
Should say "Deploying to OpenShift" rather than Kubernetes. Same goes with "Undeploying from OpenShift"
Fix typo in openshift.py provider
Add release script for Atomic App
When `sudo atomic run projectatomic/helloapache --mode=genanswers` is supplied, the resulting error shows that `--mode=genanswers` is an unrecognized argument. This was introduced after refactoring the cli/main.py code to NOT include uneeded parameters such as --provider-auth to CLI options such as init and genanswers. By moving the --mode parser to the globals_parser, each command will have the --mode option available. Fixes #792
Fixes mode argument with --mode=genanswers
Use travis CI to run tests from tests/units dir.
- Create a class representation for config data - Implement load() to load config data for a component, taking into account answers and user supplied data - Implement context() method to render flattened data to be consumed in a component artifact. - Improve API for config handling and wire up with Nulecule. - Allow comparing config instances for equality. - Added a placeholder to resolve provider config in Config. - Use ':' as namespace separator in answers and reference namespace separator from constants. - Use self.config if no config supplied in Nulecule load_config. - Store CLI data in Nulecule config. - During run/stop, reference config for provider. We are overriding provider data in config with cli provider, but when referencing provider info, we always do it from a single source of truth, config, in this case. - Update docs for Nulecule config. - Added helper in Config to retrieve resolved global params. - Centralize handling CLI answers in NuleculeManager. - process answers and cli_answers to create a nulecule.config.Config object - Include default provider, namespace in runtime answers, if missing. - Config takes default provider in spec into account. - Fixed unittests for refactored config.
- Create single source of truth for config data in NuleculeManager. Get rid of answers and cli_answers instance variables, and use only self.config to look up config data. - Allow ignoring sources when getting data from config. - Allow specifying file format when loading answers.
Don't know *exactly* why it's failing, but let's try this. Could be related to "foobar" actually going to an internal server.
0.6.3 Release
Refactor Nulecule config.
Issue with replacing version numbers, this fixes that issue with the release script
Update release script regex
0.6.4 Release
Fix CentOS CI Errors
Add checking if resource is OpenShift specific to properly create OpenShift artifacts
Can one of the admins verify this patch? |
3 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.