-
Notifications
You must be signed in to change notification settings - Fork 70
Conversation
cdrage
commented
Jan 26, 2016
- Removes mentions of install for fetch
- New year, new copyright update
- Cleans up some of descriptions
- Remove grammatical errors
``` | ||
cd atomicapp | ||
export PYTHONPATH=`pwd`:$PYTHONPATH | ||
alias atomicapp="python `pwd`/atomicapp/cli/main.py" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think this should be included ^^. let python devs do their own way of development
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind having it. Sometimes I use this and I always come back here as a reference.
Ping @dustymabe @rtnpro for review as this part is old stuff ^^ we don't use |
``` | ||
docker build -t [TAG] . | ||
``` | ||
|
||
Just a call to Docker to package up the application and tag the resulting image. | ||
Use 'docker build' to package up the application and tags the resulting image. | ||
|
||
### Install and Run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Install --> Fetch ??
Other than comments it looks good to me. |
5a67a09
to
3d4bd3a
Compare
@dustymabe updated with your comments. |
@@ -36,36 +38,35 @@ export PYTHONPATH=`pwd`:$PYTHONPATH | |||
alias atomicapp="python `pwd`/atomicapp/cli/main.py" | |||
``` | |||
|
|||
### Build | |||
### Build an Atomic App |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we be more clear about what this is doing? "Build an Atomic App" sounds like I am doing an application build (i.e. helloapache) vs packaging up the atomicapp software. Maybe this would be better: Build an Atomic App Container Image - for Container Execution
. And then mention running it via Atomic CLI?
And maybe we even want to change the name of the previous section to Install Atomic App - for Local Execution
@cdrage - can we get this updated? |
3d4bd3a
to
e3e51f3
Compare
Hey @dustymabe In regards to Otherwise, rebased again ^^ |
What we are doing is containerizing the Atomic App software so it can then be run in a container but it isn't actually an "Atomic App". I say just digest these comments and update it based on your best judgement and then MERGE!! |
e3e51f3
to
71d8cb7
Compare
@dustymabe So I'm going to push this PR for now and I'll be adding a separate section for "atomic cli" execution this week. Work on doc updating for our upcoming release :) |
I think work on #543 can continue :) |