Install requirements before make test #575
Conversation
|
LGTM 👍 @surajssd Please update your commit message to include |
surajssd
force-pushed
the
install-test-requirements
branch
2 times, most recently
from
df5e428 to
e42e49b
Compare
|
The only case where this would be bad is a setting where all of the requirements were installed via system packages (rpms) and not via pip. As long as we are ok with that.. LGTM. |
|
The usage we are propagating is via |
|
@surajssd - rebase to latest master and then we can merge. |
In a clean environment where nothing is installed and if I run `make test` then the required modules should be installed first. So before `make test` added pip install from requirements.txt and test-requirements.txt. Fixes issue projectatomic#574
surajssd
force-pushed
the
install-test-requirements
branch
from
e42e49b to
0a76aa2
Compare
|
@surajssd - next time you comply with my request you might want to ping me :) - I don't get emails when new files are pushed up, but I do when comments are added. Just say "hey, I did that thing that you asked me to do". |
Install requirements before make test
|
@dustymabe thanks and will take care of it now on! |
In a clean environment where nothing is installed and if I run
make testthen the required modules should be installed first. So beforemake testadded pip install from requirements.txt and test-requirements.txt.