This repository has been archived by the owner on Jan 19, 2018. It is now read-only.
Handle docker pull exception, improve #441, fix #568 #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concaf
force-pushed
the
DockerException_add
branch
from
d6d9419 to
67965c8
Compare
|
This makes sense rather than having NuleculeException. LGTM 👍 Let's get @dustymabe 's quick +1 on this before hand. |
|
LGTM, @cdrage can you pick this over (for possible potential breakage) and make sure all tests pass? |
|
@dustymabe test's pass, everything LGTM you can merge when ready. |
|
@containscafeine rebase and we will merge |
concaf
force-pushed
the
DockerException_add
branch
from
98acbbe to
bed3215
Compare
|
@dustymabe rebased |
|
will merge if tests pass |
|
@cdrage - did tests pass? |
|
Indeed they did! Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create
DockerExceptionto handle a specific exception instead of the generic (raise Exception) which prints out the traceback too.