Add ZAP templates to src/app

[jepenven-silabs]

Problem

PR #3464 is huge. Break down into multiples small PR to facilitate review.

Summary of Changes

Add Zap Templates in the CHIP repo

Partial Fix of #1733

[vivien-apple]

Looks pretty good. A few minor comments/nits mostly related to style consistency.

My biggest concerns would be that I would really prefer those templates to live inside examples. It would make it extra clear that they are used to generate the examples and are basically glued to them.

[vivien-apple]

@woody-apple Restyled seems to fail because of the Javascript file included in this PR (third_party/repo/templates/helper-chip.js). Do you know what is the proper way to fix it ?

[jepenven-silabs]

Looks pretty good. A few minor comments/nits mostly related to style consistency.

My biggest concerns would be that I would really prefer those templates to live inside examples. It would make it extra clear that they are used to generate the examples and are basically glued to them.

My point of view is that templates are an extension of ZAP. By themselves, they're useless. Moving them elsewhere would give the impression that they can be "standalone". And yes, as for now only the examples use them, but when people will start using CHIP for their own project, having the templates hidden under /examples won't make that much sense anymore.

[rwalker-apple]

Looks pretty good. A few minor comments/nits mostly related to style consistency.
My biggest concerns would be that I would really prefer those templates to live inside examples. It would make it extra clear that they are used to generate the examples and are basically glued to them.

My point of view is that templates are an extension of ZAP. By themselves, they're useless. Moving them elsewhere would give the impression that they can be "standalone". And yes, as for now only the examples use them, but when people will start using CHIP for their own project, having the templates hidden under /examples won't make that much sense anymore.

I think these belong under src/app, as they are part of CHIP, they're effectively libraries/source files for CHIP's interaction with ZAP.

[rwalker-apple]

please move to src/app/zapt/xxx.zapt ?

[jepenven-silabs]

please move to src/app/zapt/xxx.zapt ?
@rwalker-apple

Only the templates files or everything that is under third_party/zap/templates/ ?

[mspang]

Looks pretty good. A few minor comments/nits mostly related to style consistency.
My biggest concerns would be that I would really prefer those templates to live inside examples. It would make it extra clear that they are used to generate the examples and are basically glued to them.

My point of view is that templates are an extension of ZAP. By themselves, they're useless. Moving them elsewhere would give the impression that they can be "standalone". And yes, as for now only the examples use them, but when people will start using CHIP for their own project, having the templates hidden under /examples won't make that much sense anymore.

I think these belong under src/app, as they are part of CHIP, they're effectively libraries/source files for CHIP's interaction with ZAP.

Looks pretty good. A few minor comments/nits mostly related to style consistency.
My biggest concerns would be that I would really prefer those templates to live inside examples. It would make it extra clear that they are used to generate the examples and are basically glued to them.

My point of view is that templates are an extension of ZAP. By themselves, they're useless. Moving them elsewhere would give the impression that they can be "standalone". And yes, as for now only the examples use them, but when people will start using CHIP for their own project, having the templates hidden under /examples won't make that much sense anymore.

I think these belong under src/app, as they are part of CHIP, they're effectively libraries/source files for CHIP's interaction with ZAP.

I agree with moving them.

IMO, the things that belongs in third_party/X are

• additions that could be upstream (like adding a build file for a different build system)
• dependency readme and other administrivia (scripts to update it, etc)

For projects that add tools supporting a domain specific language such as ZAP, the sources in that language don't go in third_party. They are go in the regular directory structure of CHIP.

[vivien-apple]

@woody-apple Restyled seems to fail because of the Javascript file included in this PR (third_party/repo/templates/helper-chip.js). Do you know what is the proper way to fix it ?

I opened #3708 for that. The issue being that clang-format is trying to parse helper-chip.js but .clang-format does not contain any rules about JS files...

[rwalker-apple]

didn't want to use the name src/app/zapt?

[jepenven-silabs]

didn't want to use the name src/app/zapt?

If the folder was named zapt one could expect to only find *.zapt file inside. Also @vivien-apple requested the zap-templates.

[vivien-apple]

didn't want to use the name src/app/zapt?

If the folder was named zapt one could expect to only find *.zapt file inside. Also @vivien-apple requested the zap-templates.

This is exactly why I asked for zap-templates instead of zapt.

[jepenven-silabs]

@mspang @andy31415 so we can merge this PR.