Remove callbacks generated stubs from templates #3842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
saurabhst
approved these changes
Nov 16, 2020
BroderickCarlin
approved these changes
Nov 16, 2020
jelderton
approved these changes
Nov 16, 2020
vivien-apple
force-pushed
the
ZAP_RemoveCallbacksGeneratedStubs
branch
from
85e25f0 to
c274a0d
Compare
rwalker-apple
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The templates from #3638 generates stubs from all the clusters method. I guess the rationale is because in the case of
AppBuilderthe user can choose whether or not to integrate apluginthat will implement the body for these stubs.For the CHIP case, the "plugins" are the cluster code living under
src/app/clustersand is always here.Because of this it is unclear to me that it makes sense to generate stubs for those methods.
Summary of Changes
src/app/zap-templates/callback-stub-src.zapt