Add JavaScript to .clang-format #3708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
vivien-apple
force-pushed
the
Restyle_avoid_js
branch
from
62b80ee to
17ccdd1
Compare
vivien-apple
changed the title
|
I changed the PR to add a |
mspang
approved these changes
Nov 6, 2020
andy31415
approved these changes
Nov 6, 2020
jelderton
approved these changes
Nov 6, 2020
bzbarsky-apple
approved these changes
Nov 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e a valid format for .js file yet
Problem
Restyler complains in #3638 because it is trying to run
clang-formaton a.jsfile but.clang-formatdoes not contains rules for JS.Summary of Changes
In order to move forward with #3638 I just removed the line that add
**/*.jsfiles toclang-format.One other solution could be to add some JS rules to clang-format though.