Add attribute-size.h to src/app/zap-templates/chip-templates.json #3810
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The templates extracted from #3464 that have landed in #3638 remove the previous
gen/attribute-size.h
file and get it merged intoattribute-type.h
.That's not a bad thing but for the sake of being able to update the
gen/
folder of examples independently during the migration phase I would prefer us to keep it. It would obligate the need to updatesrc/app/attribute-size.cpp
as suggested by #3346For reference the change is:
This change means
gen/
folder generated from AppBuilder andgen/folder
generated fromZAP
won't be able to lives at the same time into the tree.I would prefer us to not have to change all the
gen/
folder at the same time, just in case something is wrong in one of the cluster used by theall-clusters-app
but that is unused for others examples such aslighting-app
,lock-app
andtemperature-measurement-app
Summary of Changes
attribute-type.zapt
into 2 different files.attribute-type.zapt
andattribute-size.zapt