Allows opening a commissioning window on a bridged node #33799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
pullapprove
bot
requested review from
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #33799: Size comparison from 4239c88 to e3f11f7 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jun 7, 2024
andy31415
reviewed
Jun 7, 2024
|
@yufengwangca please update the PR summary with a description of changes. This seems to be "add ability in the CommissioningWindowOpener to specify the endpoint, so that bridges can be supported" and "enforce the existing opencommissioningwindow to check the endpoint id, since existing implementation is for the current device (i.e. handles root endpoint only)". |
bzbarsky-apple
requested changes
Jun 7, 2024
| @@ -106,6 +108,7 @@ bool emberAfAdministratorCommissioningClusterOpenCommissioningWindowCallback( | |||
| VerifyOrExit(failSafeContext.IsFailSafeFullyDisarmed(), status.Emplace(StatusCode::kBusy)); | |||
|
|
|||
| VerifyOrExit(!commissionMgr.IsCommissioningWindowOpen(), status.Emplace(StatusCode::kBusy)); | |||
| VerifyOrExit(endpointId == kRootEndpointId, status.Emplace(StatusCode::kPAKEParameterError)); | |||
There was a problem hiding this comment.
Where is the spec basis for this?
As far as I can tell, the spec has no allowances for this sort of behavior. If you get this command, on any endpoint, you must:
- Advertise on DNS-SD.
- Enter active mode if you're an ICD.
and so on. Nothing says you have to start listening for PASE connections, though, which is arguably a spec bug. But the behavior being added here is not allowed by the spec as things stand.
There was a problem hiding this comment.
This is the implementation of the proposed fabric sync feature. For reference, see section [12.6.3.2. Aggregator Node] of the spec (the text came from https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/9106)
There was a problem hiding this comment.
Nothing in that spec section says "Ignore command invokes on the Administrator Commissioning cluster if it's not on endpoint 0".
And nothing in that section overrides (nor can it override) explicit SHALL requirements in the relevant cluster specification.
Basically, to make this work changes are needed to the actual spec for this cluster.
There was a problem hiding this comment.
Registered a ticket to clarify the intended behavior when receives OCW command not directed to Endpoint 0
https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/9354
There was a problem hiding this comment.
Great. Until that's resolved, do not make any changes to this cluster impl, please, because those changes would make it current-spec-not-compliant.
|
PR #33799: Size comparison from 4239c88 to 21d70ce Full report (50 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
|
PR #33799: Size comparison from 4239c88 to ea565c5 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #33799: Size comparison from 17cda5a to 7d61278 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33799: Size comparison from 2ee90eb to 5d735ec Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
This PR is no more valid after #34209 land, withdraw here and Abdul will create a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AdministratorCommissioningCluster is not always on endpoint 0, to open Commissioning Window on bridged node, we need to support sending an OpenCommissioningWindow command with the given parameters to the given endpoint of the given node.
Fixes #33798