Add target endpoint to CommissioningWindowOpener
#34425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samadDotDev
requested review from
robszewczyk,
tehampson,
yufengwangca and
bzbarsky-apple
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
samadDotDev
changed the title
CommissioningWindowOpener
|
PR #34425: Size comparison from 19a774a to 60dad48 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Previous #33799 is pending on whether to add the Endpoint parameter to the OpenCommissioningWindow API. This parameter is currently already part of the CommissioningWindowPasscodeParams. I believe we should avoid hardcoding it to kRootEndpointId in the SDK, particularly since the application can now set this Endpoint parameter via the public API.
tehampson
approved these changes
Jul 23, 2024
bzbarsky-apple
requested changes
Jul 23, 2024
bzbarsky-apple
approved these changes
Jul 24, 2024
Co-authored-by: Yufeng Wang <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
samadDotDev
force-pushed
the
upstream/ocw-endpoint-id
branch
from
badd7f4 to
477bf13
Compare
|
PR #34425: Size comparison from c4a25e6 to 477bf13 Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, mbed, nxp, qpg, stm32, telink, tizen)
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Add target endpoint id to commissioning window opener params Co-authored-by: Yufeng Wang <[email protected]> * Set endpoint id in fabric-admin app * Set root endpoint id by default in commissioning window params Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Yufeng Wang <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Add target endpoint id to commissioning window opener params Co-authored-by: Yufeng Wang <[email protected]> * Set endpoint id in fabric-admin app * Set root endpoint id by default in commissioning window params Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Yufeng Wang <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revives #33799 after the params API refactor.
I'm not sure if this PR needs to be strictly blocked on the issue raised in https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/9354 since this is just adding the endpoint parameter for
CommissioningWindowOpenerto target when sending out ACC (AdminCommissioningCluster) commands instead of always sending to root as being done currently, but I'll follow the conversation there to ensure if this needs to be gated by specific feature bits.The behavior of restricting endpoint ID to root in server handling of ACC command has been intentionally left out since that's definitely not spec-compliant as discussed here. Please correct my understanding if that's not the case or if there needs to be a different requirement for it.
For context: The 2-way Eco-to-Eco Fabric sync has a use case of a fabric-admin containing fabric-bridge as one of its connected devices. The requirement is to be able to direct the OCW command at a specific endpoint of the bridge [
(bridgeNodeId, bridgedEndpointId)] which will then be expected to be translated and forwarded to the relevant bridged node [(bridgedNodeId, rootOrAccEndpointId)] by the bridge.Fixes #33798