Add OCW verifier, pass params between fabric bridge & admin #34209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
|
PR #34209: Size comparison from 5a634f5 to 16bf72c Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
reviewed
Jul 9, 2024
samadDotDev
force-pushed
the
upstream/fs/ocw-params
branch
from
1707b16 to
5a9ae85
Compare
|
PR #34209: Size comparison from ecfa07a to 5a9ae85 Full report (47 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #34209: Size comparison from ecfa07a to b154a1b Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
approved these changes
Jul 9, 2024
andy31415
reviewed
Jul 11, 2024
examples/chip-tool/commands/pairing/OpenCommissioningWindowCommand.cpp
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Jul 11, 2024
andy31415
dismissed
their stale review
Buidler param changes made. Dismissing that changes requested.
examples/fabric-admin/commands/pairing/OpenCommissioningWindowCommand.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
samadDotDev
force-pushed
the
upstream/fs/ocw-params
branch
from
8862cac to
da28dd6
Compare
|
PR #34209: Size comparison from c024e4f to da28dd6 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 19, 2024
|
PR #34209: Size comparison from c024e4f to 19c0ffe Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
This was referenced Jul 19, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…chip#34209) * Add verifier arg to `CommissioningWindowOpener` * Update RPC, pass OCW params between fabric bridge and admin * Separate out OCW with passcode and verifier, bring back stable API Co-authored-by: Boris Zbarsky <[email protected]> * Use `CHIP_ERROR_BUFFER_TOO_SMALL`, Avoid SuccessOrExit, args for example Co-authored-by: Andrei Litvin <[email protected]> * Use fluent builder pattern for OCW params, and some fixes Co-authored-by: Andrei Litvin <[email protected]> * Add arg tests for new methods in `CommissioningWindowOpener` * Move callback to params Co-authored-by: Andrei Litvin <[email protected]> * Enforce param values, Add mDiscriminator, Update docs Co-authored-by: Boris Zbarsky <[email protected]> * Use `HasDiscriminator()`/`HasNodeId()`, return `ERROR_INVALID_ARGUMENT` --------- Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an optional PAKE passcode verifier arg in the commissioning window opener to support the pass-through of this parameter to the device via admin from the OCW request received on the bridge (
fabric-bridge -RPC-> fabric-admin --> device). The RPC contract update between fabric admin and fabric bridge app to pass the OCW params and use of the new function arg is done in a separate commit.Note that the OCW command which is being proxied here doesn't contain the setup pin code to compute the verifier with included iterations count.
Fixes #33763