Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inet] always copy the pbuf on lwIP platforms #20923

Merged
merged 1 commit into from
Aug 11, 2022
Merged

[Inet] always copy the pbuf on lwIP platforms #20923

merged 1 commit into from
Aug 11, 2022

Conversation

gjc13
Copy link
Contributor

@gjc13 gjc13 commented Jul 19, 2022

Problem

19393
 is causing test failures in the group session test cases. The packet buffer clone won't work if the lwIP pbuf is non-contiguous.

Change overview

Always copy the lwIP pbuf to ensure contiguous memory layout.

Testing

How was this tested? (at least one bullet point required)

  • Manually tested on ESP32 with group test case
  • CI tests

@gjc13 gjc13 requested a review from kpschoedel July 19, 2022 08:07
@boring-cyborg boring-cyborg bot added the inet label Jul 19, 2022
@github-actions
Copy link

github-actions bot commented Jul 19, 2022 •
edited
Loading

PR #20923: Size comparison from ea78432 to 84933f6

Increases (6 builds for cc13x2_26x2)
platform target config section ea78432 84933f6 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 182640 182760 120 0.1
lock-ftd LP_CC2652R7 (read/write) 169604 169732 128 0.1
lock-mtd LP_CC2652R7 (read/write) 183008 183136 128 0.1
pump-app LP_CC2652R7 (read/write) 161468 161596 128 0.1
pump-controller-app LP_CC2652R7 (read/write) 175796 175916 120 0.1
shell LP_CC2652R7 (read/write) 185644 185764 120 0.1
Decreases (19 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, p6, telink)
platform target config section ea78432 84933f6 change % change
bl602 lighting-app bl602 (read/write) 1379762 1379626 -136 -0.0
.text 1050420 1050304 -116 -0.0
bl602+rpc (read/write) 1425170 1425034 -136 -0.0
.text 1082076 1081960 -116 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668599 668479 -120 -0.0
.rodata 88319 88295 -24 -0.0
.text 579964 579868 -96 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634223 634103 -120 -0.0
.rodata 77551 77527 -24 -0.0
.text 556348 556252 -96 -0.0
lock-ftd LP_CC2652R7 (read only) 671811 671683 -128 -0.0
.rodata 76451 76427 -24 -0.0
.text 594880 594776 -104 -0.0
lock-mtd LP_CC2652R7 (read only) 654095 653967 -128 -0.0
.rodata 101199 101175 -24 -0.0
.text 552416 552312 -104 -0.0
pump-app LP_CC2652R7 (read only) 680795 680667 -128 -0.0
.rodata 88811 88787 -24 -0.0
.text 591500 591396 -104 -0.0
pump-controller-app LP_CC2652R7 (read only) 666587 666467 -120 -0.0
.rodata 84675 84651 -24 -0.0
.text 581432 581336 -96 -0.0
shell LP_CC2652R7 (read only) 661098 660978 -120 -0.0
.rodata 85098 85074 -24 -0.0
.text 575684 575588 -96 -0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 588058 588050 -8 -0.0
.app_xip_area 461892 461884 -8 -0.0
efr32 lighting-app BRD4161A+rs911x (read/write) 950160 950024 -136 -0.0
.text 807324 807188 -136 -0.0
lock-app BRD4161A+wf200 (read/write) 1128004 1127884 -120 -0.0
.text 981792 981672 -120 -0.0
esp32 all-clusters-app c3devkit (read only) 1021762 1021616 -146 -0.0
(read/write) 1486026 1486002 -24 -0.0
.flash.rodata 215912 215888 -24 -0.0
.flash.text 1021762 1021616 -146 -0.0
m5stack (read only) 1075507 1075395 -112 -0.0
(read/write) 488064 488040 -24 -0.0
.flash.rodata 246324 246300 -24 -0.0
.flash.text 1070123 1070011 -112 -0.0
p6 all-clusters-app default (read/write) 1685036 1684900 -136 -0.0
.text 1525440 1525304 -136 -0.0
all-clusters-minimal-app default (read/write) 1629180 1629044 -136 -0.0
.text 1470304 1470168 -136 -0.0
light-app default (read/write) 1549220 1549084 -136 -0.0
.text 1398648 1398512 -136 -0.0
lock-app default (read/write) 1576220 1576084 -136 -0.0
.text 1425776 1425640 -136 -0.0
telink light-switch-app tlsr9518adk80d text 566814 566810 -4 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ea78432 84933f6 change % change
bl602 lighting-app bl602 (read/write) 1379762 1379626 -136 -0.0
.bss 116962 116962 0 0.0
.data 4480 4480 0 0.0
.text 1050420 1050304 -116 -0.0
bl602+rpc (read/write) 1425170 1425034 -136 -0.0
.bss 124410 124410 0 0.0
.data 4600 4600 0 0.0
.text 1082076 1081960 -116 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668599 668479 -120 -0.0
(read/write) 182640 182760 120 0.1
.bss 74132 74132 0 0.0
.data 3356 3356 0 0.0
.rodata 88319 88295 -24 -0.0
.text 579964 579868 -96 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 634223 634103 -120 -0.0
(read/write) 157700 157700 0 0.0
.bss 73428 73428 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77527 -24 -0.0
.text 556348 556252 -96 -0.0
lock-ftd LP_CC2652R7 (read only) 671811 671683 -128 -0.0
(read/write) 169604 169732 128 0.1
.bss 71196 71196 0 0.0
.data 3280 3280 0 0.0
.rodata 76451 76427 -24 -0.0
.text 594880 594776 -104 -0.0
lock-mtd LP_CC2652R7 (read only) 654095 653967 -128 -0.0
(read/write) 183008 183136 128 0.1
.bss 66884 66884 0 0.0
.data 3280 3280 0 0.0
.rodata 101199 101175 -24 -0.0
.text 552416 552312 -104 -0.0
pump-app LP_CC2652R7 (read only) 680795 680667 -128 -0.0
(read/write) 161468 161596 128 0.1
.bss 71276 71276 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 88787 -24 -0.0
.text 591500 591396 -104 -0.0
pump-controller-app LP_CC2652R7 (read only) 666587 666467 -120 -0.0
(read/write) 175796 175916 120 0.1
.bss 71396 71396 0 0.0
.data 3276 3276 0 0.0
.rodata 84675 84651 -24 -0.0
.text 581432 581336 -96 -0.0
shell LP_CC2652R7 (read only) 661098 660978 -120 -0.0
(read/write) 185644 185764 120 0.1
.bss 76436 76436 0 0.0
.data 3360 3360 0 0.0
.rodata 85098 85074 -24 -0.0
.text 575684 575588 -96 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 582142 582142 0 0.0
.app_xip_area 460704 460704 0 0.0
.bss 64232 64232 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 588058 588050 -8 -0.0
.app_xip_area 461892 461884 -8 -0.0
.bss 68960 68960 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585474 585474 0 0.0
.app_xip_area 464884 464884 0 0.0
.bss 63440 63440 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1084792 1084792 0 0.0
.bss 133044 133044 0 0.0
.data 2048 2048 0 0.0
.text 949680 949680 0 0.0
BRD4161A+rpc (read/write) 1139084 1139084 0 0.0
.bss 149724 149724 0 0.0
.data 2260 2260 0 0.0
.text 987076 987076 0 0.0
BRD4161A+rs911x (read/write) 950160 950024 -136 -0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 807324 807188 -136 -0.0
lock-app BRD4161A+wf200 (read/write) 1128004 1127884 -120 -0.0
.bss 144136 144136 0 0.0
.data 2056 2056 0 0.0
.text 981792 981672 -120 -0.0
window-app BRD4161A (read/write) 1078284 1078284 0 0.0
.bss 134516 134516 0 0.0
.data 2076 2076 0 0.0
.text 941672 941672 0 0.0
esp32 all-clusters-app c3devkit (read only) 1021762 1021616 -146 -0.0
(read/write) 1486026 1486002 -24 -0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215912 215888 -24 -0.0
.flash.text 1021762 1021616 -146 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075507 1075395 -112 -0.0
(read/write) 488064 488040 -24 -0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246324 246300 -24 -0.0
.flash.text 1070123 1070011 -112 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660924 660924 0 0.0
.bss 69540 69540 0 0.0
.data 1992 1992 0 0.0
.text 583592 583592 0 0.0
lock k32w061+release (read/write) 687908 687908 0 0.0
.bss 70004 70004 0 0.0
.data 2004 2004 0 0.0
.text 610100 610100 0 0.0
linux all-clusters-app debug (read only) 2973161 2973161 0 0.0
(read/write) 155016 155016 0 0.0
.bss 61664 61664 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 85048 85048 0 0.0
.dynamic 608 608 0 0.0
.got 4560 4560 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 264733 264733 0 0.0
.text 2530834 2530834 0 0.0
all-clusters-minimal-app debug (read only) 2819721 2819721 0 0.0
(read/write) 146688 146688 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 265661 265661 0 0.0
.text 2379122 2379122 0 0.0
bridge-app debug+rpc (read only) 2320009 2320009 0 0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 198240 198240 0 0.0
.text 1960130 1960130 0 0.0
chip-tool debug (read only) 10295393 10295393 0 0.0
(read/write) 629504 629504 0 0.0
.bss 24728 24728 0 0.0
.data 3234 3234 0 0.0
.data.rel.ro 595152 595152 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 515765 515765 0 0.0
.text 8331604 8331604 0 0.0
chip-tool-ipv6only arm64 (read only) 10036380 10036380 0 0.0
(read/write) 694577 694577 0 0.0
.bss 42961 42961 0 0.0
.data 3304 3304 0 0.0
.data.rel.ro 630768 630768 0 0.0
.dynamic 528 528 0 0.0
.got 13624 13624 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 479820 479820 0 0.0
.text 7976596 7976596 0 0.0
lighting-app debug+rpc (read only) 2557785 2557785 0 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 214088 214088 0 0.0
.text 2173826 2173826 0 0.0
lock-app debug (read only) 2522617 2522617 0 0.0
(read/write) 124512 124512 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 229064 229064 0 0.0
.text 2128482 2128482 0 0.0
ota-provider-app debug (read only) 2326209 2326209 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203832 203832 0 0.0
.text 1959698 1959698 0 0.0
ota-requestor-app debug (read only) 2443817 2443817 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67304 67304 0 0.0
.dynamic 608 608 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207584 207584 0 0.0
.text 2065154 2065154 0 0.0
shell debug (read only) 2560065 2560065 0 0.0
(read/write) 141104 141104 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 228114 228114 0 0.0
.text 2174946 2174946 0 0.0
thermostat-no-ble arm64 (read only) 2600676 2600676 0 0.0
(read/write) 158257 158257 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83216 83216 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165748 165748 0 0.0
.text 2195184 2195184 0 0.0
tv-app debug (read only) 3108121 3108121 0 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 249504 249504 0 0.0
.text 2670818 2670818 0 0.0
tv-casting-app debug (read only) 5356241 5356241 0 0.0
(read/write) 157664 157664 0 0.0
.bss 51016 51016 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 97928 97928 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 332841 332841 0 0.0
.text 4758002 4758002 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449128 2449128 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1411772 1411772 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176643 1176643 0 0.0
bss 142900 142900 0 0.0
rodata 142204 142204 0 0.0
text 812632 812632 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156675 1156675 0 0.0
bss 142136 142136 0 0.0
rodata 133748 133748 0 0.0
text 801920 801920 0 0.0
p6 all-clusters-app default (read only) 882136 882136 0 0.0
(read/write) 1685036 1684900 -136 -0.0
.bss 148560 148560 0 0.0
.data 2648 2648 0 0.0
.text 1525440 1525304 -136 -0.0
all-clusters-minimal-app default (read only) 882856 882856 0 0.0
(read/write) 1629180 1629044 -136 -0.0
.bss 147840 147840 0 0.0
.data 2648 2648 0 0.0
.text 1470304 1470168 -136 -0.0
light-app default (read only) 891160 891160 0 0.0
(read/write) 1549220 1549084 -136 -0.0
.bss 139744 139744 0 0.0
.data 2440 2440 0 0.0
.text 1398648 1398512 -136 -0.0
lock-app default (read only) 891288 891288 0 0.0
(read/write) 1576220 1576084 -136 -0.0
.bss 139600 139600 0 0.0
.data 2456 2456 0 0.0
.text 1425776 1425640 -136 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 798700 798700 0 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 566814 566810 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 818740 818740 0 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 583346 583346 0 0.0

@gjc13 gjc13 force-pushed the lwip-udp-wrong-size branch from 84933f6 to de26a82 Compare July 21, 2022 03:28
@gjc13 gjc13 requested a review from tcarmelveilleux July 21, 2022 03:28
@github-actions
Copy link

github-actions bot commented Jul 21, 2022 •
edited
Loading

PR #20923: Size comparison from 077128d to de26a82

Increases (9 builds for cc13x2_26x2, nrfconnect, telink)
platform target config section 077128d de26a82 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 183152 183240 88 0.0
lock-ftd LP_CC2652R7 (read/write) 170108 170212 104 0.1
lock-mtd LP_CC2652R7 (read/write) 183504 183600 96 0.1
pump-app LP_CC2652R7 (read/write) 161956 162060 104 0.1
pump-controller-app LP_CC2652R7 (read/write) 176300 176396 96 0.1
shell LP_CC2652R7 (read/write) 186180 186268 88 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 811988 811992 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 801304 801308 4 0.0
telink light-switch-app tlsr9518adk80d text 566588 566590 2 0.0
Decreases (18 builds for bl602, cc13x2_26x2, efr32, esp32, p6, telink)
platform target config section 077128d de26a82 change % change
bl602 lighting-app bl602 (read/write) 1379770 1379650 -120 -0.0
.text 1050408 1050316 -92 -0.0
bl602+rpc (read/write) 1425178 1425058 -120 -0.0
.text 1082064 1081972 -92 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668095 668007 -88 -0.0
.rodata 88319 88295 -24 -0.0
.text 579460 579396 -64 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633695 633607 -88 -0.0
.rodata 77551 77527 -24 -0.0
.text 555820 555756 -64 -0.0
lock-ftd LP_CC2652R7 (read only) 671315 671211 -104 -0.0
.rodata 76443 76419 -24 -0.0
.text 594392 594312 -80 -0.0
lock-mtd LP_CC2652R7 (read only) 653607 653511 -96 -0.0
.rodata 101191 101167 -24 -0.0
.text 551936 551864 -72 -0.0
pump-app LP_CC2652R7 (read only) 680323 680219 -104 -0.0
.rodata 88811 88787 -24 -0.0
.text 591028 590948 -80 -0.0
pump-controller-app LP_CC2652R7 (read only) 666099 666003 -96 -0.0
.rodata 84675 84651 -24 -0.0
.text 580944 580872 -72 -0.0
shell LP_CC2652R7 (read only) 660570 660482 -88 -0.0
.rodata 85090 85066 -24 -0.0
.text 575164 575100 -64 -0.0
efr32 lighting-app BRD4161A+rs911x (read/write) 972132 972028 -104 -0.0
.text 808552 808448 -104 -0.0
lock-app BRD4161A+wf200 (read/write) 1127824 1127736 -88 -0.0
.text 981596 981508 -88 -0.0
esp32 all-clusters-app c3devkit (read only) 1021672 1021544 -128 -0.0
(read/write) 1486130 1486106 -24 -0.0
.flash.rodata 216000 215976 -24 -0.0
.flash.text 1021672 1021544 -128 -0.0
m5stack (read only) 1075463 1075359 -104 -0.0
(read/write) 488160 488136 -24 -0.0
.flash.rodata 246412 246388 -24 -0.0
.flash.text 1070079 1069975 -104 -0.0
p6 all-clusters-app default (read/write) 1685572 1685452 -120 -0.0
.text 1525968 1525848 -120 -0.0
all-clusters-minimal-app default (read/write) 1629684 1629580 -104 -0.0
.text 1470800 1470696 -104 -0.0
light-app default (read/write) 1549892 1549788 -104 -0.0
.text 1399312 1399208 -104 -0.0
lock-app default (read/write) 1587500 1587380 -120 -0.0
.text 1432448 1432328 -120 -0.0
telink lighting-app tlsr9518adk80d text 583134 583132 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 077128d de26a82 change % change
bl602 lighting-app bl602 (read/write) 1379770 1379650 -120 -0.0
.bss 116970 116970 0 0.0
.data 4480 4480 0 0.0
.text 1050408 1050316 -92 -0.0
bl602+rpc (read/write) 1425178 1425058 -120 -0.0
.bss 124418 124418 0 0.0
.data 4600 4600 0 0.0
.text 1082064 1081972 -92 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668095 668007 -88 -0.0
(read/write) 183152 183240 88 0.0
.bss 74140 74140 0 0.0
.data 3356 3356 0 0.0
.rodata 88319 88295 -24 -0.0
.text 579460 579396 -64 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633695 633607 -88 -0.0
(read/write) 157708 157708 0 0.0
.bss 73436 73436 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77527 -24 -0.0
.text 555820 555756 -64 -0.0
lock-ftd LP_CC2652R7 (read only) 671315 671211 -104 -0.0
(read/write) 170108 170212 104 0.1
.bss 71204 71204 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76419 -24 -0.0
.text 594392 594312 -80 -0.0
lock-mtd LP_CC2652R7 (read only) 653607 653511 -96 -0.0
(read/write) 183504 183600 96 0.1
.bss 66892 66892 0 0.0
.data 3280 3280 0 0.0
.rodata 101191 101167 -24 -0.0
.text 551936 551864 -72 -0.0
pump-app LP_CC2652R7 (read only) 680323 680219 -104 -0.0
(read/write) 161956 162060 104 0.1
.bss 71292 71292 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 88787 -24 -0.0
.text 591028 590948 -80 -0.0
pump-controller-app LP_CC2652R7 (read only) 666099 666003 -96 -0.0
(read/write) 176300 176396 96 0.1
.bss 71412 71412 0 0.0
.data 3276 3276 0 0.0
.rodata 84675 84651 -24 -0.0
.text 580944 580872 -72 -0.0
shell LP_CC2652R7 (read only) 660570 660482 -88 -0.0
(read/write) 186180 186268 88 0.0
.bss 76444 76444 0 0.0
.data 3360 3360 0 0.0
.rodata 85090 85066 -24 -0.0
.text 575164 575100 -64 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581642 581642 0 0.0
.app_xip_area 460192 460192 0 0.0
.bss 64244 64244 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587566 587566 0 0.0
.app_xip_area 461388 461388 0 0.0
.bss 68972 68972 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585014 585014 0 0.0
.app_xip_area 464412 464412 0 0.0
.bss 63452 63452 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1086016 1086016 0 0.0
.bss 133060 133060 0 0.0
.data 2048 2048 0 0.0
.text 950888 950888 0 0.0
BRD4161A+rpc (read/write) 1140292 1140292 0 0.0
.bss 149732 149732 0 0.0
.data 2260 2260 0 0.0
.text 988276 988276 0 0.0
BRD4161A+rs911x (read/write) 972132 972028 -104 -0.0
.bss 161512 161512 0 0.0
.data 2048 2048 0 0.0
.text 808552 808448 -104 -0.0
lock-app BRD4161A+wf200 (read/write) 1127824 1127736 -88 -0.0
.bss 144152 144152 0 0.0
.data 2056 2056 0 0.0
.text 981596 981508 -88 -0.0
window-app BRD4161A (read/write) 1079508 1079508 0 0.0
.bss 134532 134532 0 0.0
.data 2076 2076 0 0.0
.text 942880 942880 0 0.0
esp32 all-clusters-app c3devkit (read only) 1021672 1021544 -128 -0.0
(read/write) 1486130 1486106 -24 -0.0
.dram0.bss 70088 70088 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216000 215976 -24 -0.0
.flash.text 1021672 1021544 -128 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075463 1075359 -104 -0.0
(read/write) 488160 488136 -24 -0.0
.dram0.bss 75608 75608 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246412 246388 -24 -0.0
.flash.text 1070079 1069975 -104 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660424 660424 0 0.0
.bss 69540 69540 0 0.0
.data 1992 1992 0 0.0
.text 583092 583092 0 0.0
lock k32w061+release (read/write) 687404 687404 0 0.0
.bss 70012 70012 0 0.0
.data 2004 2004 0 0.0
.text 609588 609588 0 0.0
linux all-clusters-app debug (read only) 2978593 2978593 0 0.0
(read/write) 155312 155312 0 0.0
.bss 61824 61824 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85160 85160 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 264779 264779 0 0.0
.text 2535842 2535842 0 0.0
all-clusters-minimal-app debug (read only) 2824545 2824545 0 0.0
(read/write) 146984 146984 0 0.0
.bss 61024 61024 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77720 77720 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 265675 265675 0 0.0
.text 2383554 2383554 0 0.0
bridge-app debug+rpc (read only) 2324657 2324657 0 0.0
(read/write) 125768 125768 0 0.0
.bss 49088 49088 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67096 67096 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 198184 198184 0 0.0
.text 1964450 1964450 0 0.0
chip-tool debug (read only) 10347905 10347905 0 0.0
(read/write) 631848 631848 0 0.0
.bss 24760 24760 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 597416 597416 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 520629 520629 0 0.0
.text 8373828 8373828 0 0.0
chip-tool-ipv6only arm64 (read only) 9771188 9771188 0 0.0
(read/write) 679361 679361 0 0.0
.bss 32833 32833 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 624760 624760 0 0.0
.dynamic 560 560 0 0.0
.got 13544 13544 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 456884 456884 0 0.0
.text 7730084 7730084 0 0.0
lighting-app debug+rpc (read only) 2562401 2562401 0 0.0
(read/write) 129856 129856 0 0.0
.bss 49664 49664 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 214000 214000 0 0.0
.text 2178146 2178146 0 0.0
lock-app debug (read only) 2527281 2527281 0 0.0
(read/write) 124808 124808 0 0.0
.bss 48032 48032 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69208 69208 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 229008 229008 0 0.0
.text 2132818 2132818 0 0.0
ota-provider-app debug (read only) 2330865 2330865 0 0.0
(read/write) 118608 118608 0 0.0
.bss 47680 47680 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63192 63192 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 203800 203800 0 0.0
.text 1964002 1964002 0 0.0
ota-requestor-app debug (read only) 2449465 2449465 0 0.0
(read/write) 125544 125544 0 0.0
.bss 50048 50048 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67416 67416 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 207552 207552 0 0.0
.text 2070450 2070450 0 0.0
shell debug (read only) 2565105 2565105 0 0.0
(read/write) 141336 141336 0 0.0
.bss 57608 57608 0 0.0
.data 1248 1248 0 0.0
.data.rel.ro 76792 76792 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 228082 228082 0 0.0
.text 2179634 2179634 0 0.0
thermostat-no-ble arm64 (read only) 2338540 2338540 0 0.0
(read/write) 141233 141233 0 0.0
.bss 55265 55265 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75552 75552 0 0.0
.dynamic 560 560 0 0.0
.got 4976 4976 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 138964 138964 0 0.0
.text 1962928 1962928 0 0.0
tv-app debug (read only) 3112921 3112921 0 0.0
(read/write) 256960 256960 0 0.0
.bss 167064 167064 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78728 78728 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 249512 249512 0 0.0
.text 2675154 2675154 0 0.0
tv-casting-app debug (read only) 5366473 5366473 0 0.0
(read/write) 158264 158264 0 0.0
.bss 51256 51256 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98288 98288 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 333601 333601 0 0.0
.text 4766514 4766514 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448816 2448816 0 0.0
.bss 213948 213948 0 0.0
.data 5872 5872 0 0.0
.text 1411460 1411460 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176003 1176003 0 0.0
bss 142908 142908 0 0.0
rodata 142204 142204 0 0.0
text 811988 811992 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156067 1156067 0 0.0
bss 142144 142144 0 0.0
rodata 133748 133748 0 0.0
text 801304 801308 4 0.0
p6 all-clusters-app default (read only) 882128 882128 0 0.0
(read/write) 1685572 1685452 -120 -0.0
.bss 148568 148568 0 0.0
.data 2648 2648 0 0.0
.text 1525968 1525848 -120 -0.0
all-clusters-minimal-app default (read only) 882848 882848 0 0.0
(read/write) 1629684 1629580 -104 -0.0
.bss 147848 147848 0 0.0
.data 2648 2648 0 0.0
.text 1470800 1470696 -104 -0.0
light-app default (read only) 891152 891152 0 0.0
(read/write) 1549892 1549788 -104 -0.0
.bss 139752 139752 0 0.0
.data 2440 2440 0 0.0
.text 1399312 1399208 -104 -0.0
lock-app default (read only) 886680 886680 0 0.0
(read/write) 1587500 1587380 -120 -0.0
.bss 144208 144208 0 0.0
.data 2456 2456 0 0.0
.text 1432448 1432328 -120 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 798452 798452 0 0.0
bss 70584 70584 0 0.0
noinit 40416 40416 0 0.0
text 566588 566590 2 0.0
lighting-app tlsr9518adk80d (read/write) 818500 818500 0 0.0
bss 71428 71428 0 0.0
noinit 40416 40416 0 0.0
text 583134 583132 -2 -0.0

@gjc13 gjc13 force-pushed the lwip-udp-wrong-size branch from de26a82 to a11d055 Compare July 22, 2022 03:50
@github-actions
Copy link

github-actions bot commented Jul 22, 2022 •
edited
Loading

PR #20923: Size comparison from eeb75da to a11d055

Increases (8 builds for cc13x2_26x2, k32w, telink)
platform target config section eeb75da a11d055 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 182960 183056 96 0.1
lock-ftd LP_CC2652R7 (read/write) 169932 170028 96 0.1
lock-mtd LP_CC2652R7 (read/write) 183336 183424 88 0.0
pump-app LP_CC2652R7 (read/write) 161288 161384 96 0.1
pump-controller-app LP_CC2652R7 (read/write) 175632 175736 104 0.1
shell LP_CC2652R7 (read/write) 185988 186084 96 0.1
k32w light k32w061+release (read/write) 660800 660816 16 0.0
.text 583340 583356 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 799460 799468 8 0.0
text 567184 567186 2 0.0
Decreases (17 builds for bl602, cc13x2_26x2, efr32, esp32, p6)
platform target config section eeb75da a11d055 change % change
bl602 lighting-app bl602 (read/write) 1380794 1380674 -120 -0.0
.text 1050932 1050836 -96 -0.0
bl602+rpc (read/write) 1426202 1426090 -112 -0.0
.text 1082588 1082496 -92 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668383 668287 -96 -0.0
.rodata 88327 88303 -24 -0.0
.text 579740 579668 -72 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633983 633879 -104 -0.0
.rodata 77551 77527 -24 -0.0
.text 556108 556028 -80 -0.0
lock-ftd LP_CC2652R7 (read only) 671587 671491 -96 -0.0
.rodata 76443 76419 -24 -0.0
.text 594664 594592 -72 -0.0
lock-mtd LP_CC2652R7 (read only) 653871 653783 -88 -0.0
.rodata 101183 101159 -24 -0.0
.text 552208 552144 -64 -0.0
pump-app LP_CC2652R7 (read only) 681087 680991 -96 -0.0
.rodata 89039 89015 -24 -0.0
.text 591564 591492 -72 -0.0
pump-controller-app LP_CC2652R7 (read only) 666863 666759 -104 -0.0
.rodata 84895 84871 -24 -0.0
.text 581488 581408 -80 -0.0
shell LP_CC2652R7 (read only) 660858 660762 -96 -0.0
.rodata 85098 85074 -24 -0.0
.text 575444 575372 -72 -0.0
efr32 lighting-app BRD4161A+rs911x (read/write) 972716 972612 -104 -0.0
.text 808984 808880 -104 -0.0
lock-app BRD4161A+wf200 (read/write) 1128224 1128136 -88 -0.0
.text 981844 981756 -88 -0.0
esp32 all-clusters-app c3devkit (read only) 1021924 1021794 -130 -0.0
(read/write) 1486274 1486250 -24 -0.0
.flash.rodata 216016 215992 -24 -0.0
.flash.text 1021924 1021794 -130 -0.0
m5stack (read only) 1075563 1075487 -76 -0.0
(read/write) 488304 488280 -24 -0.0
.flash.rodata 246420 246396 -24 -0.0
.flash.text 1070179 1070103 -76 -0.0
p6 all-clusters-app default (read/write) 1686436 1686332 -104 -0.0
.text 1526336 1526232 -104 -0.0
all-clusters-minimal-app default (read/write) 1630540 1630452 -88 -0.0
.text 1471160 1471072 -88 -0.0
light-app default (read/write) 1550780 1550692 -88 -0.0
.text 1399704 1399616 -88 -0.0
lock-app default (read/write) 1588372 1588284 -88 -0.0
.text 1432824 1432736 -88 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section eeb75da a11d055 change % change
bl602 lighting-app bl602 (read/write) 1380794 1380674 -120 -0.0
.bss 117474 117474 0 0.0
.data 4480 4480 0 0.0
.text 1050932 1050836 -96 -0.0
bl602+rpc (read/write) 1426202 1426090 -112 -0.0
.bss 124922 124922 0 0.0
.data 4600 4600 0 0.0
.text 1082588 1082496 -92 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668383 668287 -96 -0.0
(read/write) 182960 183056 96 0.1
.bss 74236 74236 0 0.0
.data 3356 3356 0 0.0
.rodata 88327 88303 -24 -0.0
.text 579740 579668 -72 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633983 633879 -104 -0.0
(read/write) 157804 157804 0 0.0
.bss 73532 73532 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77527 -24 -0.0
.text 556108 556028 -80 -0.0
lock-ftd LP_CC2652R7 (read only) 671587 671491 -96 -0.0
(read/write) 169932 170028 96 0.1
.bss 71300 71300 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76419 -24 -0.0
.text 594664 594592 -72 -0.0
lock-mtd LP_CC2652R7 (read only) 653871 653783 -88 -0.0
(read/write) 183336 183424 88 0.0
.bss 66988 66988 0 0.0
.data 3280 3280 0 0.0
.rodata 101183 101159 -24 -0.0
.text 552208 552144 -64 -0.0
pump-app LP_CC2652R7 (read only) 681087 680991 -96 -0.0
(read/write) 161288 161384 96 0.1
.bss 71388 71388 0 0.0
.data 3280 3280 0 0.0
.rodata 89039 89015 -24 -0.0
.text 591564 591492 -72 -0.0
pump-controller-app LP_CC2652R7 (read only) 666863 666759 -104 -0.0
(read/write) 175632 175736 104 0.1
.bss 71508 71508 0 0.0
.data 3276 3276 0 0.0
.rodata 84895 84871 -24 -0.0
.text 581488 581408 -80 -0.0
shell LP_CC2652R7 (read only) 660858 660762 -96 -0.0
(read/write) 185988 186084 96 0.1
.bss 76540 76540 0 0.0
.data 3360 3360 0 0.0
.rodata 85098 85074 -24 -0.0
.text 575444 575372 -72 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 582082 582082 0 0.0
.app_xip_area 460472 460472 0 0.0
.bss 64404 64404 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587998 587998 0 0.0
.app_xip_area 461660 461660 0 0.0
.bss 69132 69132 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 586286 586286 0 0.0
.app_xip_area 465524 465524 0 0.0
.bss 63612 63612 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1087488 1087488 0 0.0
.bss 133220 133220 0 0.0
.data 2048 2048 0 0.0
.text 952200 952200 0 0.0
BRD4161A+rpc (read/write) 1141780 1141780 0 0.0
.bss 149892 149892 0 0.0
.data 2260 2260 0 0.0
.text 989604 989604 0 0.0
BRD4161A+rs911x (read/write) 972716 972612 -104 -0.0
.bss 161664 161664 0 0.0
.data 2048 2048 0 0.0
.text 808984 808880 -104 -0.0
lock-app BRD4161A+wf200 (read/write) 1128224 1128136 -88 -0.0
.bss 144304 144304 0 0.0
.data 2056 2056 0 0.0
.text 981844 981756 -88 -0.0
window-app BRD4161A (read/write) 1080980 1080980 0 0.0
.bss 134692 134692 0 0.0
.data 2076 2076 0 0.0
.text 944192 944192 0 0.0
esp32 all-clusters-app c3devkit (read only) 1021924 1021794 -130 -0.0
(read/write) 1486274 1486250 -24 -0.0
.dram0.bss 70224 70224 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216016 215992 -24 -0.0
.flash.text 1021924 1021794 -130 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075563 1075487 -76 -0.0
(read/write) 488304 488280 -24 -0.0
.dram0.bss 75744 75744 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246420 246396 -24 -0.0
.flash.text 1070179 1070103 -76 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660800 660816 16 0.0
.bss 69668 69668 0 0.0
.data 1992 1992 0 0.0
.text 583340 583356 16 0.0
lock k32w061+release (read/write) 687820 687820 0 0.0
.bss 70140 70140 0 0.0
.data 2004 2004 0 0.0
.text 609876 609876 0 0.0
linux all-clusters-app debug (read only) 2981177 2981177 0 0.0
(read/write) 155344 155344 0 0.0
.bss 61792 61792 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 85224 85224 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 265739 265739 0 0.0
.text 2537298 2537298 0 0.0
all-clusters-minimal-app debug (read only) 2827073 2827073 0 0.0
(read/write) 147016 147016 0 0.0
.bss 60992 60992 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 77784 77784 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 266603 266603 0 0.0
.text 2385010 2385010 0 0.0
bridge-app debug+rpc (read only) 2341777 2341777 0 0.0
(read/write) 126920 126920 0 0.0
.bss 50080 50080 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67240 67240 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 199240 199240 0 0.0
.text 1980226 1980226 0 0.0
chip-tool debug (read only) 10349249 10349249 0 0.0
(read/write) 631912 631912 0 0.0
.bss 24760 24760 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 597480 597480 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 521813 521813 0 0.0
.text 8373844 8373844 0 0.0
chip-tool-ipv6only arm64 (read only) 9778876 9778876 0 0.0
(read/write) 679441 679441 0 0.0
.bss 32833 32833 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 624824 624824 0 0.0
.dynamic 560 560 0 0.0
.got 13552 13552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 457580 457580 0 0.0
.text 7736900 7736900 0 0.0
lighting-app debug+rpc (read only) 2564897 2564897 0 0.0
(read/write) 129888 129888 0 0.0
.bss 49632 49632 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72296 72296 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 214896 214896 0 0.0
.text 2179602 2179602 0 0.0
lock-app debug (read only) 2529921 2529921 0 0.0
(read/write) 124872 124872 0 0.0
.bss 48032 48032 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69272 69272 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 229936 229936 0 0.0
.text 2134386 2134386 0 0.0
ota-provider-app debug (read only) 2333505 2333505 0 0.0
(read/write) 118672 118672 0 0.0
.bss 47680 47680 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63256 63256 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 204728 204728 0 0.0
.text 1965570 1965570 0 0.0
ota-requestor-app debug (read only) 2451961 2451961 0 0.0
(read/write) 125576 125576 0 0.0
.bss 50016 50016 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 67480 67480 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 208448 208448 0 0.0
.text 2071906 2071906 0 0.0
shell debug (read only) 2567785 2567785 0 0.0
(read/write) 141400 141400 0 0.0
.bss 57608 57608 0 0.0
.data 1248 1248 0 0.0
.data.rel.ro 76856 76856 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229042 229042 0 0.0
.text 2181186 2181186 0 0.0
thermostat-no-ble arm64 (read only) 2341532 2341532 0 0.0
(read/write) 141265 141265 0 0.0
.bss 55233 55233 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75616 75616 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139444 139444 0 0.0
.text 1965248 1965248 0 0.0
tv-app debug (read only) 3115553 3115553 0 0.0
(read/write) 257024 257024 0 0.0
.bss 167064 167064 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 78792 78792 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 250440 250440 0 0.0
.text 2676690 2676690 0 0.0
tv-casting-app debug (read only) 5369265 5369265 0 0.0
(read/write) 158328 158328 0 0.0
.bss 51256 51256 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 98352 98352 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 334625 334625 0 0.0
.text 4768114 4768114 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2449032 2449032 0 0.0
.bss 214444 214444 0 0.0
.data 5872 5872 0 0.0
.text 1411676 1411676 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176927 1176927 0 0.0
bss 143068 143068 0 0.0
rodata 142440 142440 0 0.0
text 812548 812548 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156979 1156979 0 0.0
bss 142304 142304 0 0.0
rodata 133972 133972 0 0.0
text 801860 801860 0 0.0
p6 all-clusters-app default (read only) 881632 881632 0 0.0
(read/write) 1686436 1686332 -104 -0.0
.bss 149064 149064 0 0.0
.data 2648 2648 0 0.0
.text 1526336 1526232 -104 -0.0
all-clusters-minimal-app default (read only) 882352 882352 0 0.0
(read/write) 1630540 1630452 -88 -0.0
.bss 148344 148344 0 0.0
.data 2648 2648 0 0.0
.text 1471160 1471072 -88 -0.0
light-app default (read only) 890656 890656 0 0.0
(read/write) 1550780 1550692 -88 -0.0
.bss 140248 140248 0 0.0
.data 2440 2440 0 0.0
.text 1399704 1399616 -88 -0.0
lock-app default (read only) 886184 886184 0 0.0
(read/write) 1588372 1588284 -88 -0.0
.bss 144704 144704 0 0.0
.data 2456 2456 0 0.0
.text 1432824 1432736 -88 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 799460 799468 8 0.0
bss 70744 70744 0 0.0
noinit 40416 40416 0 0.0
text 567184 567186 2 0.0
lighting-app tlsr9518adk80d (read/write) 819516 819516 0 0.0
bss 71588 71588 0 0.0
noinit 40416 40416 0 0.0
text 583730 583730 0 0.0

@rosahay-silabs rosahay-silabs mentioned this pull request Aug 1, 2022
Open
@bzbarsky-apple
Copy link
Contributor

I am wondering: wouldn't a better fix, given #19393, be:

  1. Fix ReservedSize to check for contiguous buffer.
  2. Fix CloneData to just copy the data if the reserved size is 0, which it can do via public API that should work on non-contiguous buffers.

Then we would not need to do the copy-on-incoming-every-time thing, I would think.

That can be a followup to this PR, obviously; please make sure there's an issue tracking that if it makes sense.

@gjc13 gjc13 force-pushed the lwip-udp-wrong-size branch from a11d055 to b674860 Compare August 4, 2022 11:15
@gjc13
Copy link
Contributor Author

gjc13 commented Aug 4, 2022

I am wondering: wouldn't a better fix, given #19393, be:

  1. Fix ReservedSize to check for contiguous buffer.
  2. Fix CloneData to just copy the data if the reserved size is 0, which it can do via public API that should work on non-contiguous buffers.

Then we would not need to do the copy-on-incoming-every-time thing, I would think.

That can be a followup to this PR, obviously; please make sure there's an issue tracking that if it makes sense.

I am wondering: wouldn't a better fix, given #19393, be:

  1. Fix ReservedSize to check for contiguous buffer.
  2. Fix CloneData to just copy the data if the reserved size is 0, which it can do via public API that should work on non-contiguous buffers.

Then we would not need to do the copy-on-incoming-every-time thing, I would think.

That can be a followup to this PR, obviously; please make sure there's an issue tracking that if it makes sense.

TODO added.

@github-actions
Copy link

github-actions bot commented Aug 4, 2022 •
edited
Loading

PR #20923: Size comparison from f646b00 to b674860

Increases (6 builds for cc13x2_26x2)
platform target config section f646b00 b674860 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 180716 180812 96 0.1
lock-ftd LP_CC2652R7 (read/write) 168416 168512 96 0.1
lock-mtd LP_CC2652R7 (read/write) 181700 181804 104 0.1
pump-app LP_CC2652R7 (read/write) 159640 159728 88 0.1
pump-controller-app LP_CC2652R7 (read/write) 175304 175400 96 0.1
shell LP_CC2652R7 (read/write) 183568 183664 96 0.1
Decreases (20 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, p6, telink)
platform target config section f646b00 b674860 change % change
bl602 lighting-app bl602 (read/write) 1380202 1380090 -112 -0.0
.text 1048308 1048216 -92 -0.0
bl602+rpc (read/write) 1425458 1425338 -120 -0.0
.text 1079808 1079716 -92 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670667 670571 -96 -0.0
.rodata 88539 88515 -24 -0.0
.text 581812 581740 -72 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636195 636099 -96 -0.0
.rodata 77795 77771 -24 -0.0
.text 558076 558004 -72 -0.0
lock-ftd LP_CC2652R7 (read only) 673151 673055 -96 -0.0
.rodata 76607 76583 -24 -0.0
.text 596064 595992 -72 -0.0
lock-mtd LP_CC2652R7 (read only) 655555 655451 -104 -0.0
.rodata 101467 101443 -24 -0.0
.text 553608 553528 -80 -0.0
pump-app LP_CC2652R7 (read only) 682735 682647 -88 -0.0
.rodata 89271 89247 -24 -0.0
.text 592980 592916 -64 -0.0
pump-controller-app LP_CC2652R7 (read only) 667207 667111 -96 -0.0
.rodata 84815 84791 -24 -0.0
.text 581912 581840 -72 -0.0
shell LP_CC2652R7 (read only) 663334 663238 -96 -0.0
.rodata 85486 85462 -24 -0.0
.text 577532 577460 -72 -0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 590718 590710 -8 -0.0
.app_xip_area 462744 462736 -8 -0.0
efr32 lighting-app BRD4161A+rs911x (read/write) 977368 977280 -88 -0.0
.text 813512 813424 -88 -0.0
lock-app BRD4161A+wf200 (read/write) 1130896 1130792 -104 -0.0
.text 984400 984296 -104 -0.0
esp32 all-clusters-app c3devkit (read only) 1025490 1025354 -136 -0.0
(read/write) 1487234 1487210 -24 -0.0
.flash.rodata 216864 216840 -24 -0.0
.flash.text 1025490 1025354 -136 -0.0
m5stack (read only) 1078935 1078827 -108 -0.0
(read/write) 489232 489208 -24 -0.0
.flash.rodata 247260 247236 -24 -0.0
.flash.text 1073551 1073443 -108 -0.0
p6 all-clusters-app default (read/write) 1690500 1690396 -104 -0.0
.text 1530296 1530192 -104 -0.0
all-clusters-minimal-app default (read/write) 1634692 1634604 -88 -0.0
.text 1475208 1475120 -88 -0.0
light-app default (read/write) 1554980 1554892 -88 -0.0
.text 1403816 1403728 -88 -0.0
lock-app default (read/write) 1592268 1592164 -104 -0.0
.text 1436608 1436504 -104 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 805768 805760 -8 -0.0
text 569550 569548 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 827440 827432 -8 -0.0
text 587390 587386 -4 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section f646b00 b674860 change % change
bl602 lighting-app bl602 (read/write) 1380202 1380090 -112 -0.0
.bss 119746 119746 0 0.0
.data 4480 4480 0 0.0
.text 1048308 1048216 -92 -0.0
bl602+rpc (read/write) 1425458 1425338 -120 -0.0
.bss 127186 127186 0 0.0
.data 4600 4600 0 0.0
.text 1079808 1079716 -92 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 670667 670571 -96 -0.0
(read/write) 180716 180812 96 0.1
.bss 74276 74276 0 0.0
.data 3372 3372 0 0.0
.rodata 88539 88515 -24 -0.0
.text 581812 581740 -72 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 636195 636099 -96 -0.0
(read/write) 157844 157844 0 0.0
.bss 73556 73556 0 0.0
.data 3372 3372 0 0.0
.rodata 77795 77771 -24 -0.0
.text 558076 558004 -72 -0.0
lock-ftd LP_CC2652R7 (read only) 673151 673055 -96 -0.0
(read/write) 168416 168512 96 0.1
.bss 71348 71348 0 0.0
.data 3296 3296 0 0.0
.rodata 76607 76583 -24 -0.0
.text 596064 595992 -72 -0.0
lock-mtd LP_CC2652R7 (read only) 655555 655451 -104 -0.0
(read/write) 181700 181804 104 0.1
.bss 67036 67036 0 0.0
.data 3296 3296 0 0.0
.rodata 101467 101443 -24 -0.0
.text 553608 553528 -80 -0.0
pump-app LP_CC2652R7 (read only) 682735 682647 -88 -0.0
(read/write) 159640 159728 88 0.1
.bss 71388 71388 0 0.0
.data 3296 3296 0 0.0
.rodata 89271 89247 -24 -0.0
.text 592980 592916 -64 -0.0
pump-controller-app LP_CC2652R7 (read only) 667207 667111 -96 -0.0
(read/write) 175304 175400 96 0.1
.bss 71524 71524 0 0.0
.data 3292 3292 0 0.0
.rodata 84815 84791 -24 -0.0
.text 581912 581840 -72 -0.0
shell LP_CC2652R7 (read only) 663334 663238 -96 -0.0
(read/write) 183568 183664 96 0.1
.bss 76596 76596 0 0.0
.data 3376 3376 0 0.0
.rodata 85486 85462 -24 -0.0
.text 577532 577460 -72 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584814 584814 0 0.0
.app_xip_area 461624 461624 0 0.0
.bss 65632 65632 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590718 590710 -8 -0.0
.app_xip_area 462744 462736 -8 -0.0
.bss 70416 70416 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 590038 590038 0 0.0
.app_xip_area 467656 467656 0 0.0
.bss 64880 64880 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1090900 1090900 0 0.0
.bss 133292 133292 0 0.0
.data 2064 2064 0 0.0
.text 955524 955524 0 0.0
BRD4161A+rpc (read/write) 1145196 1145196 0 0.0
.bss 149972 149972 0 0.0
.data 2276 2276 0 0.0
.text 992924 992924 0 0.0
BRD4161A+rs911x (read/write) 977368 977280 -88 -0.0
.bss 161784 161784 0 0.0
.data 2052 2052 0 0.0
.text 813512 813424 -88 -0.0
lock-app BRD4161A+wf200 (read/write) 1130896 1130792 -104 -0.0
.bss 144416 144416 0 0.0
.data 2060 2060 0 0.0
.text 984400 984296 -104 -0.0
window-app BRD4161A (read/write) 1082644 1082644 0 0.0
.bss 134748 134748 0 0.0
.data 2092 2092 0 0.0
.text 945784 945784 0 0.0
esp32 all-clusters-app c3devkit (read only) 1025490 1025354 -136 -0.0
(read/write) 1487234 1487210 -24 -0.0
.dram0.bss 70336 70336 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216864 216840 -24 -0.0
.flash.text 1025490 1025354 -136 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1078935 1078827 -108 -0.0
(read/write) 489232 489208 -24 -0.0
.dram0.bss 75832 75832 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 247260 247236 -24 -0.0
.flash.text 1073551 1073443 -108 -0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 644408 644408 0 0.0
.bss 69720 69720 0 0.0
.data 2044 2044 0 0.0
.text 569916 569916 0 0.0
lock k32w0+release (read/write) 701720 701720 0 0.0
.bss 70184 70184 0 0.0
.data 2052 2052 0 0.0
.text 626756 626756 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9849660 9849660 0 0.0
(read/write) 694033 694033 0 0.0
.bss 32897 32897 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 639264 639264 0 0.0
.dynamic 560 560 0 0.0
.got 13624 13624 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 463452 463452 0 0.0
.text 7759204 7759204 0 0.0
thermostat-no-ble arm64 (read only) 2347660 2347660 0 0.0
(read/write) 141601 141601 0 0.0
.bss 55313 55313 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75832 75832 0 0.0
.dynamic 560 560 0 0.0
.got 5016 5016 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 139572 139572 0 0.0
.text 1970672 1970672 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453424 2453424 0 0.0
.bss 214548 214548 0 0.0
.data 5872 5872 0 0.0
.text 1416068 1416068 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177455 1177455 0 0.0
bss 143222 143222 0 0.0
rodata 142736 142736 0 0.0
text 812656 812656 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1157527 1157527 0 0.0
bss 142460 142460 0 0.0
rodata 134432 134432 0 0.0
text 801812 801812 0 0.0
p6 all-clusters-app default (read only) 881528 881528 0 0.0
(read/write) 1690500 1690396 -104 -0.0
.bss 149168 149168 0 0.0
.data 2648 2648 0 0.0
.text 1530296 1530192 -104 -0.0
all-clusters-minimal-app default (read only) 882248 882248 0 0.0
(read/write) 1634692 1634604 -88 -0.0
.bss 148448 148448 0 0.0
.data 2648 2648 0 0.0
.text 1475208 1475120 -88 -0.0
light-app default (read only) 890568 890568 0 0.0
(read/write) 1554980 1554892 -88 -0.0
.bss 140336 140336 0 0.0
.data 2440 2440 0 0.0
.text 1403816 1403728 -88 -0.0
lock-app default (read only) 886072 886072 0 0.0
(read/write) 1592268 1592164 -104 -0.0
.bss 144816 144816 0 0.0
.data 2456 2456 0 0.0
.text 1436608 1436504 -104 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 805768 805760 -8 -0.0
bss 70976 70976 0 0.0
noinit 43488 43488 0 0.0
text 569550 569548 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 827440 827432 -8 -0.0
bss 71820 71820 0 0.0
noinit 43488 43488 0 0.0
text 587390 587386 -4 -0.0

@bzbarsky-apple bzbarsky-apple merged commit 4c4b383 into project-chip:master Aug 11, 2022
This was referenced Aug 11, 2022
Closed
Closed
@bzbarsky-apple
Copy link
Contributor

This PR seems to be causing out-of-pbufs failures on devices: #21832

isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@gjc13 @isiu-apple
[Inet] always copy the pbuf on lwIP platforms (project-chip#20923)
1833410
@itrifler
Copy link

In LwIPReceiveUDPMessage, the new operation will be performed, when there are many udp packets in the local area network, the memory consumption will be too fast. Have you encountered similar problems?

@wqx6 wqx6 mentioned this pull request Oct 28, 2022
Merged
@wqx6 wqx6 mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@andy31415 andy31415 Awaiting requested review from andy31415

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@saurabhst saurabhst Awaiting requested review from saurabhst

@chshu chshu Awaiting requested review from chshu

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
cert blocker inet review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gjc13 @bzbarsky-apple @itrifler @tcarmelveilleux @andy31415 @chshu @woody-apple @jmeg-sfy