Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to reuse the lwIP pbuf in UDPEndPointImplLwIP.cpp #21816

Closed
gjc13 opened this issue Aug 11, 2022 · 2 comments · Fixed by #25679
Closed

Try to reuse the lwIP pbuf in UDPEndPointImplLwIP.cpp #21816

gjc13 opened this issue Aug 11, 2022 · 2 comments · Fixed by #25679

Comments

@gjc13
Copy link
Contributor

gjc13 commented Aug 11, 2022

Problem

Currently all the UDP packets are copied to fit the PacketBuffer memory model.

Proposed Solution

Check the memory layout of the lwIP pbuf and reuse it if it already fits the PacketBuffer.

@gjc13 gjc13 added the inet label Aug 11, 2022
@bzbarsky-apple
Copy link
Contributor

Per #20923 (comment) I think we can do better than that and only copy when copying is actually needed, but just make sure we do it correctly for non-inline pbufs.

@stale
Copy link

stale bot commented Feb 11, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Feb 11, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Feb 13, 2023
@bzbarsky-apple bzbarsky-apple linked a pull request Mar 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants