inet: Do not copy pbuf when it already meets the PacketBuffer memory #23376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
msandstedt,
rgoliver,
robszewczyk and
saurabhst
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #23376: Size comparison from 753cb9c to 84c267d Increases (21 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, psoc6, telink)
Decreases (7 builds for cc13x2_26x2, telink)
Full report (47 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 29, 2022
|
That said, is there a reason this wasn't done via the approach described in #20923 (comment) ? That seem like it would avoid the copy even for the non-contiguous buffer case.... |
andy31415
approved these changes
Oct 29, 2022
wqx6
force-pushed
the
inet/struct_data_contiguous
branch
from
84c267d to
c97997f
Compare
I am not sure whether we should use adopt the non-contiguous buffer to the PacketBuffer model in Matter. Many APIs of the PacketBuffer is designed based on the contiguous model. |
|
PR #23376: Size comparison from 81a64dc to c97997f Increases (20 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, psoc6, telink)
Decreases (8 builds for cc13x2_26x2, qpg, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Apart from the ones dealing with reserved space, which ones? @wqx6 |
For example, when we call |
It should fail for the non-contiguous case.
It should keep returning 0. |
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…roject-chip#23376) * inet: Do not copy pbuf when it already meets the PacketBuffer memory model on LwIP platforms * Restyled by clang-format * Review changes Co-authored-by: Restyled.io <[email protected]>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…roject-chip#23376) * inet: Do not copy pbuf when it already meets the PacketBuffer memory model on LwIP platforms * Restyled by clang-format * Review changes Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #20923, the LwIP pbuf will always be copied to a new created PacketBuffer.
We should adopt the LwIP pbuf to the Packet Buffer if it already meets the PacketBuffer memory model.