[Inet] always copy the pbuf on lwIP platforms

project-chip · Jul 21, 2022 · de26a82 · de26a82
1 parent ea78432
commit de26a82
Showing 1 changed file with 10 additions and 21 deletions.
diff --git a/src/inet/UDPEndPointImplLwIP.cpp b/src/inet/UDPEndPointImplLwIP.cpp
@@ -352,31 +352,19 @@ CHIP_ERROR UDPEndPointImplLwIP::GetPCB(IPAddressType addrType)
 void UDPEndPointImplLwIP::LwIPReceiveUDPMessage(void * arg, struct udp_pcb * pcb, struct pbuf * p, const ip_addr_t * addr,
                                                 u16_t port)
 {
-    UDPEndPointImplLwIP * ep       = static_cast<UDPEndPointImplLwIP *>(arg);
-    IPPacketInfo * pktInfo         = nullptr;
-    System::PacketBufferHandle buf = System::PacketBufferHandle::Adopt(p);
-
+    UDPEndPointImplLwIP * ep = static_cast<UDPEndPointImplLwIP *>(arg);
+    IPPacketInfo * pktInfo   = nullptr;
     if (ep->mState == State::kClosed)
-        return;
-
-    if (buf->HasChainedBuffer())
     {
-        // Try the simple expedient of flattening in-place.
-        buf->CompactHead();
+        pbuf_free(p);
+        return;
     }
-
-    if (buf->HasChainedBuffer())
+    System::PacketBufferHandle buf = System::PacketBufferHandle::New(p->tot_len);
+    if (buf.IsNull() || pbuf_copy_partial(p, buf->Start(), p->tot_len, 0) != p->tot_len)
     {
-        // Have to allocate a new big-enough buffer and copy.
-        uint16_t messageSize            = buf->TotalLength();
-        System::PacketBufferHandle copy = System::PacketBufferHandle::New(messageSize, 0);
-        if (copy.IsNull() || buf->Read(copy->Start(), messageSize) != CHIP_NO_ERROR)
-        {
-            ChipLogError(Inet, "No memory to flatten incoming packet buffer chain of size %u", buf->TotalLength());
-            return;
-        }
-        buf = std::move(copy);
+        ChipLogError(Inet, "Cannot copy received pbuf of size %u", p->tot_len);
     }
+    buf->SetDataLength(p->tot_len);
 
     pktInfo = GetPacketInfo(buf);
     if (pktInfo != nullptr)
@@ -388,10 +376,11 @@ void UDPEndPointImplLwIP::LwIPReceiveUDPMessage(void * arg, struct udp_pcb * pcb
         pktInfo->DestPort    = pcb->local_port;
     }
 
-    // TODO: add thread-safe reference counting for UDP endpoints
     CHIP_ERROR err = ep->GetSystemLayer().ScheduleLambda([ep, p = System::LwIPPacketBufferView::UnsafeGetLwIPpbuf(buf)] {
         ep->HandleDataReceived(System::PacketBufferHandle::Adopt(p));
     });
+
+    pbuf_free(p);
     if (err == CHIP_NO_ERROR)
     {
         // If ScheduleLambda() succeeded, it has ownership of the buffer, so we need to release it (without freeing it).