Add storage audit codepaths to Server #20134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Storage audit will soon be conducted to determine readiness of platforms in terms of compliance of the storage API implementations. - This PR adds a no-op audit disabled by default Testing done: - `scripts/examples/gn_build_example.sh examples/all-clusters-app/linux out/debug/standalone chip_config_network_layer_ble=false chip_support_enable_storage_api_audit=true chip_support_enable_storage_load_test_audit=true` shows that the audits run and succeed, and without the arguments, they are not executed at all and don't appear in the final binary.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel and
lazarkov
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
bzbarsky-apple
approved these changes
Jun 29, 2022
|
PR #20134: Size comparison from f03b9ae to 9ff94b8 Increases (4 builds for cc13x2_26x2, cyw30739, esp32)
Decreases (4 builds for cc13x2_26x2, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #20134: Size comparison from f03b9ae to 589b657 Increases (10 builds for cc13x2_26x2, cyw30739, nrfconnect, telink)
Decreases (7 builds for cc13x2_26x2)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tehampson
approved these changes
Jun 30, 2022
woody-apple
pushed a commit
to woody-apple/connectedhomeip
that referenced
this pull request
Jun 30, 2022
* Add storage audit codepaths to Server - Storage audit will soon be conducted to determine readiness of platforms in terms of compliance of the storage API implementations. - This PR adds a no-op audit disabled by default Testing done: - `scripts/examples/gn_build_example.sh examples/all-clusters-app/linux out/debug/standalone chip_config_network_layer_ble=false chip_support_enable_storage_api_audit=true chip_support_enable_storage_load_test_audit=true` shows that the audits run and succeed, and without the arguments, they are not executed at all and don't appear in the final binary. * Restyled by clang-format * Restyled by gn Co-authored-by: Restyled.io <[email protected]>
This was referenced Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
in terms of compliance of the storage API implementations.
Testing
scripts/examples/gn_build_example.sh examples/all-clusters-app/linux out/debug/standalone chip_config_network_layer_ble=false chip_support_enable_storage_api_audit=true chip_support_enable_storage_load_test_audit=trueshows that the audits run and succeed, and without the arguments,
they are not executed at all and don't appear in the final binary.