Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure nRF Connect platform storage backend succeeds Storage audit #20201

Closed
Damian-Nordic opened this issue Jul 1, 2022 · 0 comments · Fixed by #20298
Closed

Ensure nRF Connect platform storage backend succeeds Storage audit #20201

Damian-Nordic opened this issue Jul 1, 2022 · 0 comments · Fixed by #20298

Comments

@Damian-Nordic
Copy link
Contributor

Damian-Nordic commented Jul 1, 2022

Problem

PR #20134 and #20164 together introduced a storage API compliance audit.

This audit must be run and pass on nRF Connect and succeed against PersistentStorageDelegate used by lock-app (KVS file based)

To run the audit for anything using Server, build your target with chip_support_enable_storage_api_audit=true added to your GN args and then run your binary in a debugger. The default audit is added to Server::Init() and will cause an assert with logs on failure.

Audit passes once you see the following string in your logs

  • ==== PersistentStorageDelegate API audit: SUCCESS ====

On failure, informative assertion failures are logged to assist in debugging.

Proposed Solution

  • Build with audit enabled
  • Run and comment on passing along with the SHA of the commit where it was run. Provide a logs capture of your run.
  • If you find failures, please document them in comments on the issue to help SDK team audit the types of failures/assumptions made.
  • Close the issue once you pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant