Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infineon] Fix CYW30739 KVS to pass the storage API audit. #21995

Merged
merged 1 commit into from
Aug 22, 2022
Merged

[Infineon] Fix CYW30739 KVS to pass the storage API audit. #21995

merged 1 commit into from
Aug 22, 2022

Conversation

hsusid
Copy link
Contributor

@hsusid hsusid commented Aug 18, 2022 •
edited
Loading

Problem

Fixes #22030

#20134 and #20164 provide a storage API compliance audit to verify the platform KVS storage implementations.
Current CYW30739 KVS implementations fail to pass the storage API compliance audit.

Change overview

  • Support key length up to PersistentStorageDelegate::kKeyLengthMax.
  • _Get and _Put methods can handle zero-size data correctly.

Testing

Build with API audit enabled:
gn gen out/debug --args="chip_error_logging=true chip_openthread_ftd=false chip_support_enable_storage_api_audit=true"

API audit passes with the following line:
ErrM CHIP:ATM: ==== PersistentStorageDelegate API audit: SUCCESS ====

@pullapprove pullapprove bot removed the platform label Aug 18, 2022
@github-actions
Copy link

github-actions bot commented Aug 18, 2022 •
edited
Loading

PR #21995: Size comparison from 1ea6bbe to d5f07ce

Increases (6 builds for bl602, cc13x2_26x2, cyw30739, telink)
platform target config section 1ea6bbe d5f07ce change % change
bl602 lighting-app bl602 .text 1051040 1051044 4 0.0
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 157752 157760 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586030 586094 64 0.0
.app_xip_area 462696 462760 64 0.0
lock cyw930739m2evb_01 (read/write) 591846 591910 64 0.0
.app_xip_area 463728 463792 64 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 598970 599026 56 0.0
.app_xip_area 476356 476412 56 0.0
telink light-switch-app tlsr9518adk80d text 571314 571316 2 0.0
Decreases (3 builds for cc13x2_26x2, esp32)
platform target config section 1ea6bbe d5f07ce change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 637747 637739 -8 -0.0
.text 559444 559436 -8 -0.0
pump-app LP_CC2652R7 (read only) 684751 684743 -8 -0.0
.text 594308 594300 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1030792 1030790 -2 -0.0
.flash.text 1030792 1030790 -2 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1ea6bbe d5f07ce change % change
bl602 lighting-app bl602 (read/write) 1383858 1383858 0 0.0
.bss 120258 120258 0 0.0
.data 4480 4480 0 0.0
.text 1051040 1051044 4 0.0
bl602+rpc (read/write) 1429370 1429370 0 0.0
.bss 127698 127698 0 0.0
.data 4600 4600 0 0.0
.text 1082800 1082800 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672795 672795 0 0.0
(read/write) 178700 178700 0 0.0
.bss 74388 74388 0 0.0
.data 3372 3372 0 0.0
.rodata 88819 88819 0 0.0
.text 583660 583660 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637747 637739 -8 -0.0
(read/write) 157948 157948 0 0.0
.bss 73660 73660 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559444 559436 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 674079 674079 0 0.0
(read/write) 167616 167616 0 0.0
.bss 71476 71476 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596928 596928 0 0.0
lock-mtd LP_CC2652R7 (read only) 656831 656831 0 0.0
(read/write) 180552 180552 0 0.0
.bss 67164 67164 0 0.0
.data 3296 3296 0 0.0
.rodata 101759 101759 0 0.0
.text 554592 554592 0 0.0
pump-app LP_CC2652R7 (read only) 684751 684743 -8 -0.0
(read/write) 157752 157760 8 0.0
.bss 71516 71516 0 0.0
.data 3296 3296 0 0.0
.rodata 89959 89959 0 0.0
.text 594308 594300 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 669243 669243 0 0.0
(read/write) 173380 173380 0 0.0
.bss 71636 71636 0 0.0
.data 3292 3292 0 0.0
.rodata 85515 85515 0 0.0
.text 583248 583248 0 0.0
shell LP_CC2652R7 (read only) 665478 665478 0 0.0
(read/write) 181536 181536 0 0.0
.bss 76708 76708 0 0.0
.data 3376 3376 0 0.0
.rodata 85766 85766 0 0.0
.text 579396 579396 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586030 586094 64 0.0
.app_xip_area 462696 462760 64 0.0
.bss 65768 65768 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591846 591910 64 0.0
.app_xip_area 463728 463792 64 0.0
.bss 70552 70552 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 598970 599026 56 0.0
.app_xip_area 476356 476412 56 0.0
.bss 65080 65080 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1100964 1100964 0 0.0
.bss 133372 133372 0 0.0
.data 2068 2068 0 0.0
.text 965500 965500 0 0.0
BRD4161A+rpc (read/write) 1155216 1155216 0 0.0
.bss 150060 150060 0 0.0
.data 2280 2280 0 0.0
.text 1002856 1002856 0 0.0
BRD4161A+rs911x (read/write) 990152 990152 0 0.0
.bss 162696 162696 0 0.0
.data 2056 2056 0 0.0
.text 825380 825380 0 0.0
lock-app BRD4161A+wf200 (read/write) 1139620 1139620 0 0.0
.bss 145872 145872 0 0.0
.data 2064 2064 0 0.0
.text 991664 991664 0 0.0
window-app BRD4161A (read/write) 1092420 1092420 0 0.0
.bss 134812 134812 0 0.0
.data 2096 2096 0 0.0
.text 955492 955492 0 0.0
esp32 all-clusters-app c3devkit (read only) 1030792 1030790 -2 -0.0
(read/write) 1489570 1489570 0 0.0
.dram0.bss 71136 71136 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 218400 218400 0 0.0
.flash.text 1030792 1030790 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1083967 1083967 0 0.0
(read/write) 491496 491496 0 0.0
.dram0.bss 76640 76640 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248716 248716 0 0.0
.flash.text 1078583 1078583 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 646676 646676 0 0.0
.bss 70400 70400 0 0.0
.data 2068 2068 0 0.0
.text 571480 571480 0 0.0
lock k32w0+release (read/write) 704196 704196 0 0.0
.bss 70864 70864 0 0.0
.data 2076 2076 0 0.0
.text 628528 628528 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10212956 10212956 0 0.0
(read/write) 699905 699905 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 644592 644592 0 0.0
.dynamic 560 560 0 0.0
.got 13784 13784 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 490636 490636 0 0.0
.text 8082404 8082404 0 0.0
thermostat-no-ble arm64 (read only) 2357300 2357300 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140620 140620 0 0.0
.text 1978960 1978960 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454328 2454328 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1416972 1416972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180367 1180367 0 0.0
bss 143737 143737 0 0.0
rodata 143344 143344 0 0.0
text 814448 814448 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159799 1159799 0 0.0
bss 142964 142964 0 0.0
rodata 134944 134944 0 0.0
text 803072 803072 0 0.0
p6 all-clusters-app default (read only) 881000 881000 0 0.0
(read/write) 1699804 1699804 0 0.0
.bss 149688 149688 0 0.0
.data 2656 2656 0 0.0
.text 1539072 1539072 0 0.0
all-clusters-minimal-app default (read only) 881736 881736 0 0.0
(read/write) 1643276 1643276 0 0.0
.bss 148952 148952 0 0.0
.data 2656 2656 0 0.0
.text 1483280 1483280 0 0.0
light-app default (read only) 890080 890080 0 0.0
(read/write) 1560532 1560532 0 0.0
.bss 140816 140816 0 0.0
.data 2448 2448 0 0.0
.text 1408880 1408880 0 0.0
lock-app default (read only) 885584 885584 0 0.0
(read/write) 1597812 1597812 0 0.0
.bss 145296 145296 0 0.0
.data 2464 2464 0 0.0
.text 1441664 1441664 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808736 808736 0 0.0
bss 71448 71448 0 0.0
noinit 43488 43488 0 0.0
text 571314 571316 2 0.0
lighting-app tlsr9518adk80d (read/write) 830672 830672 0 0.0
bss 72304 72304 0 0.0
noinit 43488 43488 0 0.0
text 589404 589404 0 0.0

@hsusid hsusid mentioned this pull request Aug 19, 2022
Closed
@hsusid hsusid force-pushed the cyw30739-kvs-audit-fix branch from d5f07ce to 6387902 Compare August 19, 2022 02:15
@hsusid
Copy link
Contributor Author

hsusid commented Aug 19, 2022

rebase to re-trigger CI

@github-actions
Copy link

github-actions bot commented Aug 19, 2022 •
edited
Loading

PR #21995: Size comparison from 18247f4 to 6387902

Increases (6 builds for cc13x2_26x2, cyw30739, psoc6)
platform target config section 18247f4 6387902 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 656823 656831 8 0.0
.text 554584 554592 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586618 586682 64 0.0
.app_xip_area 463284 463348 64 0.0
lock cyw930739m2evb_01 (read/write) 592418 592482 64 0.0
.app_xip_area 464300 464364 64 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599538 599594 56 0.0
.app_xip_area 476924 476980 56 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26643195 26643196 1 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26379889 26379890 1 0.0
Decreases (3 builds for cc13x2_26x2, esp32, telink)
platform target config section 18247f4 6387902 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 180560 180552 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1031270 1031268 -2 -0.0
.flash.text 1031270 1031268 -2 -0.0
telink lighting-app tlsr9518adk80d text 589408 589406 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section 18247f4 6387902 change % change
bl602 lighting-app bl602 (read/write) 1383858 1383858 0 0.0
.bss 120258 120258 0 0.0
.data 4480 4480 0 0.0
.text 1051044 1051044 0 0.0
bl602+rpc (read/write) 1429370 1429370 0 0.0
.bss 127698 127698 0 0.0
.data 4600 4600 0 0.0
.text 1082800 1082800 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 673027 673027 0 0.0
(read/write) 178468 178468 0 0.0
.bss 74388 74388 0 0.0
.data 3372 3372 0 0.0
.rodata 88835 88835 0 0.0
.text 583876 583876 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637747 637747 0 0.0
(read/write) 157948 157948 0 0.0
.bss 73660 73660 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559444 559444 0 0.0
lock-ftd LP_CC2652R7 (read only) 674079 674079 0 0.0
(read/write) 167616 167616 0 0.0
.bss 71476 71476 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596928 596928 0 0.0
lock-mtd LP_CC2652R7 (read only) 656823 656831 8 0.0
(read/write) 180560 180552 -8 -0.0
.bss 67164 67164 0 0.0
.data 3296 3296 0 0.0
.rodata 101759 101759 0 0.0
.text 554584 554592 8 0.0
pump-app LP_CC2652R7 (read only) 684751 684751 0 0.0
(read/write) 157752 157752 0 0.0
.bss 71516 71516 0 0.0
.data 3296 3296 0 0.0
.rodata 89959 89959 0 0.0
.text 594308 594308 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669243 669243 0 0.0
(read/write) 173380 173380 0 0.0
.bss 71636 71636 0 0.0
.data 3292 3292 0 0.0
.rodata 85515 85515 0 0.0
.text 583248 583248 0 0.0
shell LP_CC2652R7 (read only) 665710 665710 0 0.0
(read/write) 181304 181304 0 0.0
.bss 76708 76708 0 0.0
.data 3376 3376 0 0.0
.rodata 85782 85782 0 0.0
.text 579612 579612 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586618 586682 64 0.0
.app_xip_area 463284 463348 64 0.0
.bss 65768 65768 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592418 592482 64 0.0
.app_xip_area 464300 464364 64 0.0
.bss 70552 70552 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599538 599594 56 0.0
.app_xip_area 476924 476980 56 0.0
.bss 65080 65080 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1100980 1100980 0 0.0
.bss 133372 133372 0 0.0
.data 2068 2068 0 0.0
.text 965516 965516 0 0.0
BRD4161A+rpc (read/write) 1155232 1155232 0 0.0
.bss 150060 150060 0 0.0
.data 2280 2280 0 0.0
.text 1002872 1002872 0 0.0
BRD4161A+rs911x (read/write) 990152 990152 0 0.0
.bss 162696 162696 0 0.0
.data 2056 2056 0 0.0
.text 825380 825380 0 0.0
lock-app BRD4161A+wf200 (read/write) 1139636 1139636 0 0.0
.bss 145872 145872 0 0.0
.data 2064 2064 0 0.0
.text 991680 991680 0 0.0
window-app BRD4161A (read/write) 1092420 1092420 0 0.0
.bss 134812 134812 0 0.0
.data 2096 2096 0 0.0
.text 955492 955492 0 0.0
esp32 all-clusters-app c3devkit (read only) 1031270 1031268 -2 -0.0
(read/write) 1489610 1489610 0 0.0
.dram0.bss 71136 71136 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 218440 218440 0 0.0
.flash.text 1031270 1031268 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1084371 1084371 0 0.0
(read/write) 491544 491544 0 0.0
.dram0.bss 76640 76640 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248764 248764 0 0.0
.flash.text 1078987 1078987 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 646676 646676 0 0.0
.bss 70400 70400 0 0.0
.data 2068 2068 0 0.0
.text 571480 571480 0 0.0
lock k32w0+release (read/write) 704196 704196 0 0.0
.bss 70864 70864 0 0.0
.data 2076 2076 0 0.0
.text 628528 628528 0 0.0
linux all-clusters-app debug (read only) 3038505 3038505 0 0.0
(read/write) 156024 156024 0 0.0
.bss 61920 61920 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 85624 85624 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 274667 274667 0 0.0
.text 2584690 2584690 0 0.0
all-clusters-minimal-app debug (read only) 2874353 2874353 0 0.0
(read/write) 147624 147624 0 0.0
.bss 61152 61152 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 78120 78120 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 274859 274859 0 0.0
.text 2423122 2423122 0 0.0
bridge-app debug+rpc (read only) 2373001 2373001 0 0.0
(read/write) 127584 127584 0 0.0
.bss 50656 50656 0 0.0
.data 3600 3600 0 0.0
.data.rel.ro 67464 67464 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 203496 203496 0 0.0
.text 2006882 2006882 0 0.0
chip-tool debug (read only) 10868673 10868673 0 0.0
(read/write) 651296 651296 0 0.0
.bss 25240 25240 0 0.0
.data 3266 3266 0 0.0
.data.rel.ro 616280 616280 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 562677 562677 0 0.0
.text 8799364 8799364 0 0.0
chip-tool-ipv6only arm64 (read only) 10255980 10255980 0 0.0
(read/write) 699105 699105 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 643792 643792 0 0.0
.dynamic 560 560 0 0.0
.got 13784 13784 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493340 493340 0 0.0
.text 8124596 8124596 0 0.0
lighting-app debug+rpc (read only) 2597033 2597033 0 0.0
(read/write) 130176 130176 0 0.0
.bss 49760 49760 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72360 72360 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 220304 220304 0 0.0
.text 2206018 2206018 0 0.0
lock-app debug (read only) 2580929 2580929 0 0.0
(read/write) 125512 125512 0 0.0
.bss 48288 48288 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69512 69512 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 237360 237360 0 0.0
.text 2176914 2176914 0 0.0
ota-provider-app debug (read only) 2358105 2358105 0 0.0
(read/write) 118976 118976 0 0.0
.bss 47808 47808 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 63336 63336 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 209336 209336 0 0.0
.text 1985298 1985298 0 0.0
ota-requestor-app debug (read only) 2523369 2523369 0 0.0
(read/write) 127320 127320 0 0.0
.bss 50336 50336 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 68728 68728 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 216160 216160 0 0.0
.text 2134642 2134642 0 0.0
shell debug (read only) 2606793 2606793 0 0.0
(read/write) 142144 142144 0 0.0
.bss 57832 57832 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77224 77224 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 234770 234770 0 0.0
.text 2213602 2213602 0 0.0
thermostat-no-ble arm64 (read only) 2357300 2357300 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140620 140620 0 0.0
.text 1978960 1978960 0 0.0
tv-app debug (read only) 3173993 3173993 0 0.0
(read/write) 257968 257968 0 0.0
.bss 167480 167480 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 79184 79184 0 0.0
.dynamic 608 608 0 0.0
.got 4856 4856 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 258952 258952 0 0.0
.text 2725298 2725298 0 0.0
tv-casting-app debug (read only) 5466769 5466769 0 0.0
(read/write) 160400 160400 0 0.0
.bss 51448 51448 0 0.0
.data 2432 2432 0 0.0
.data.rel.ro 100088 100088 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 343729 343729 0 0.0
.text 4851522 4851522 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454328 2454328 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1416972 1416972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180603 1180603 0 0.0
bss 143737 143737 0 0.0
rodata 143356 143356 0 0.0
text 814664 814664 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159799 1159799 0 0.0
bss 142964 142964 0 0.0
rodata 134944 134944 0 0.0
text 803072 803072 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 881000 881000 0 0.0
(read/write) 1700996 1700996 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 149688 149688 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1217459 1217459 0 0.0
.debug_aranges 111528 111528 0 0.0
.debug_frame 372352 372352 0 0.0
.debug_info 26643195 26643196 1 0.0
.debug_line 3646638 3646638 0 0.0
.debug_loc 3562036 3562036 0 0.0
.debug_ranges 336576 336576 0 0.0
.debug_str 3393852 3393852 0 0.0
.heap 881000 881000 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569346 569346 0 0.0
.symtab 420416 420416 0 0.0
.text 1540264 1540264 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 881736 881736 0 0.0
(read/write) 1644204 1644204 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 148952 148952 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1209298 1209298 0 0.0
.debug_aranges 111000 111000 0 0.0
.debug_frame 375432 375432 0 0.0
.debug_info 26379889 26379890 1 0.0
.debug_line 3667042 3667042 0 0.0
.debug_loc 3549673 3549673 0 0.0
.debug_ranges 335192 335192 0 0.0
.debug_str 3382841 3382841 0 0.0
.heap 881736 881736 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533820 533820 0 0.0
.symtab 407008 407008 0 0.0
.text 1484208 1484208 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 890080 890080 0 0.0
(read/write) 1561436 1561436 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 140816 140816 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2448 2448 0 0.0
.debug_abbrev 1043971 1043971 0 0.0
.debug_aranges 103168 103168 0 0.0
.debug_frame 345676 345676 0 0.0
.debug_info 21844446 21844446 0 0.0
.debug_line 3238220 3238220 0 0.0
.debug_loc 3249205 3249205 0 0.0
.debug_ranges 301032 301032 0 0.0
.debug_str 3188935 3188935 0 0.0
.heap 890080 890080 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 467101 467101 0 0.0
.symtab 374064 374064 0 0.0
.text 1409784 1409784 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 885584 885584 0 0.0
(read/write) 1598708 1598708 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 145296 145296 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1051147 1051147 0 0.0
.debug_aranges 103840 103840 0 0.0
.debug_frame 348500 348500 0 0.0
.debug_info 22199615 22199615 0 0.0
.debug_line 3246906 3246906 0 0.0
.debug_loc 3289325 3289325 0 0.0
.debug_ranges 304448 304448 0 0.0
.debug_str 3216366 3216366 0 0.0
.heap 885584 885584 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473342 473342 0 0.0
.symtab 377248 377248 0 0.0
.text 1442560 1442560 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808744 808744 0 0.0
bss 71448 71448 0 0.0
noinit 43488 43488 0 0.0
text 571318 571318 0 0.0
lighting-app tlsr9518adk80d (read/write) 830680 830680 0 0.0
bss 72304 72304 0 0.0
noinit 43488 43488 0 0.0
text 589408 589406 -2 -0.0

@hsusid
[Infineon] Fix CYW30739 KVS to pass the storage API audit.
3f78f82 
* Support key length upto PersistentStorageDelegate::kKeyLengthMax.
* _Get and _Put methods can handle zero-size data correctly.
@hsusid hsusid force-pushed the cyw30739-kvs-audit-fix branch from 6387902 to 3f78f82 Compare August 21, 2022 06:45
@github-actions
Copy link

github-actions bot commented Aug 21, 2022 •
edited
Loading

PR #21995: Size comparison from a8d12af to 3f78f82

Increases (6 builds for cyw30739, psoc6)
platform target config section a8d12af 3f78f82 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 586626 586682 56 0.0
.app_xip_area 463292 463348 56 0.0
lock cyw930739m2evb_01 (read/write) 592426 592490 64 0.0
.app_xip_area 464308 464372 64 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599546 599602 56 0.0
.app_xip_area 476932 476988 56 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26643194 26643195 1 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26379889 26379890 1 0.0
lock cy8ckit_062s2_43012 .debug_info 22199614 22199615 1 0.0
Decreases (4 builds for cc13x2_26x2, esp32, psoc6, telink)
platform target config section a8d12af 3f78f82 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 637755 637747 -8 -0.0
.text 559452 559444 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1031268 1031266 -2 -0.0
.flash.text 1031268 1031266 -2 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 21844448 21844447 -1 -0.0
telink light-switch-app tlsr9518adk80d text 571316 571314 -2 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section a8d12af 3f78f82 change % change
bl602 lighting-app bl602 (read/write) 1383866 1383866 0 0.0
.bss 120258 120258 0 0.0
.data 4480 4480 0 0.0
.text 1051052 1051052 0 0.0
bl602+rpc (read/write) 1429378 1429378 0 0.0
.bss 127698 127698 0 0.0
.data 4600 4600 0 0.0
.text 1082808 1082808 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 673035 673035 0 0.0
(read/write) 178460 178460 0 0.0
.bss 74388 74388 0 0.0
.data 3372 3372 0 0.0
.rodata 88835 88835 0 0.0
.text 583884 583884 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637755 637747 -8 -0.0
(read/write) 157948 157948 0 0.0
.bss 73660 73660 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559452 559444 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 674087 674087 0 0.0
(read/write) 167608 167608 0 0.0
.bss 71476 71476 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596936 596936 0 0.0
lock-mtd LP_CC2652R7 (read only) 656839 656839 0 0.0
(read/write) 180544 180544 0 0.0
.bss 67164 67164 0 0.0
.data 3296 3296 0 0.0
.rodata 101759 101759 0 0.0
.text 554600 554600 0 0.0
pump-app LP_CC2652R7 (read only) 684759 684759 0 0.0
(read/write) 157744 157744 0 0.0
.bss 71516 71516 0 0.0
.data 3296 3296 0 0.0
.rodata 89959 89959 0 0.0
.text 594316 594316 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669251 669251 0 0.0
(read/write) 173372 173372 0 0.0
.bss 71636 71636 0 0.0
.data 3292 3292 0 0.0
.rodata 85515 85515 0 0.0
.text 583256 583256 0 0.0
shell LP_CC2652R7 (read only) 665718 665718 0 0.0
(read/write) 181296 181296 0 0.0
.bss 76708 76708 0 0.0
.data 3376 3376 0 0.0
.rodata 85782 85782 0 0.0
.text 579620 579620 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586626 586682 56 0.0
.app_xip_area 463292 463348 56 0.0
.bss 65768 65768 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592426 592490 64 0.0
.app_xip_area 464308 464372 64 0.0
.bss 70552 70552 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599546 599602 56 0.0
.app_xip_area 476932 476988 56 0.0
.bss 65080 65080 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1104716 1104716 0 0.0
.bss 133572 133572 0 0.0
.data 2072 2072 0 0.0
.text 969052 969052 0 0.0
BRD4161A+rpc (read/write) 967916 967916 0 0.0
.bss 147572 147572 0 0.0
.data 2252 2252 0 0.0
.text 818068 818068 0 0.0
BRD4161A+rs911x (read/write) 997968 997968 0 0.0
.bss 166992 166992 0 0.0
.data 2056 2056 0 0.0
.text 828900 828900 0 0.0
lock-app BRD4161A+wf200 (read/write) 1147332 1147332 0 0.0
.bss 150168 150168 0 0.0
.data 2064 2064 0 0.0
.text 995080 995080 0 0.0
window-app BRD4161A (read/write) 1096044 1096044 0 0.0
.bss 135012 135012 0 0.0
.data 2096 2096 0 0.0
.text 958916 958916 0 0.0
esp32 all-clusters-app c3devkit (read only) 1031268 1031266 -2 -0.0
(read/write) 1489610 1489610 0 0.0
.dram0.bss 71136 71136 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 218440 218440 0 0.0
.flash.text 1031268 1031266 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1084371 1084371 0 0.0
(read/write) 491544 491544 0 0.0
.dram0.bss 76640 76640 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248764 248764 0 0.0
.flash.text 1078987 1078987 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 646676 646676 0 0.0
.bss 70400 70400 0 0.0
.data 2068 2068 0 0.0
.text 571480 571480 0 0.0
lock k32w0+release (read/write) 704212 704212 0 0.0
.bss 70864 70864 0 0.0
.data 2076 2076 0 0.0
.text 628544 628544 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10259132 10259132 0 0.0
(read/write) 699137 699137 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 643824 643824 0 0.0
.dynamic 560 560 0 0.0
.got 13784 13784 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493564 493564 0 0.0
.text 8127428 8127428 0 0.0
thermostat-no-ble arm64 (read only) 2357300 2357300 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140620 140620 0 0.0
.text 1978960 1978960 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454328 2454328 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1416972 1416972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180603 1180603 0 0.0
bss 143737 143737 0 0.0
rodata 143356 143356 0 0.0
text 814672 814672 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159815 1159815 0 0.0
bss 142964 142964 0 0.0
rodata 134944 134944 0 0.0
text 803080 803080 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 881000 881000 0 0.0
(read/write) 1700996 1700996 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 149688 149688 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1217459 1217459 0 0.0
.debug_aranges 111528 111528 0 0.0
.debug_frame 372352 372352 0 0.0
.debug_info 26643194 26643195 1 0.0
.debug_line 3646641 3646641 0 0.0
.debug_loc 3562036 3562036 0 0.0
.debug_ranges 336576 336576 0 0.0
.debug_str 3393852 3393852 0 0.0
.heap 881000 881000 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569346 569346 0 0.0
.symtab 420416 420416 0 0.0
.text 1540264 1540264 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 881736 881736 0 0.0
(read/write) 1644204 1644204 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 148952 148952 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1209298 1209298 0 0.0
.debug_aranges 111000 111000 0 0.0
.debug_frame 375432 375432 0 0.0
.debug_info 26379889 26379890 1 0.0
.debug_line 3667045 3667045 0 0.0
.debug_loc 3549673 3549673 0 0.0
.debug_ranges 335192 335192 0 0.0
.debug_str 3382841 3382841 0 0.0
.heap 881736 881736 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533820 533820 0 0.0
.symtab 407008 407008 0 0.0
.text 1484208 1484208 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 890080 890080 0 0.0
(read/write) 1561436 1561436 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 140816 140816 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2448 2448 0 0.0
.debug_abbrev 1043971 1043971 0 0.0
.debug_aranges 103168 103168 0 0.0
.debug_frame 345676 345676 0 0.0
.debug_info 21844448 21844447 -1 -0.0
.debug_line 3238223 3238223 0 0.0
.debug_loc 3249205 3249205 0 0.0
.debug_ranges 301032 301032 0 0.0
.debug_str 3188935 3188935 0 0.0
.heap 890080 890080 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 467101 467101 0 0.0
.symtab 374064 374064 0 0.0
.text 1409784 1409784 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 885584 885584 0 0.0
(read/write) 1598724 1598724 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 145296 145296 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1051147 1051147 0 0.0
.debug_aranges 103840 103840 0 0.0
.debug_frame 348500 348500 0 0.0
.debug_info 22199614 22199615 1 0.0
.debug_line 3246909 3246909 0 0.0
.debug_loc 3289325 3289325 0 0.0
.debug_ranges 304448 304448 0 0.0
.debug_str 3216366 3216366 0 0.0
.heap 885584 885584 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473342 473342 0 0.0
.symtab 377248 377248 0 0.0
.text 1442576 1442576 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808736 808736 0 0.0
bss 71448 71448 0 0.0
noinit 43488 43488 0 0.0
text 571316 571314 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 830680 830680 0 0.0
bss 72304 72304 0 0.0
noinit 43488 43488 0 0.0
text 589406 589406 0 0.0

@andy31415 andy31415 merged commit 3899b66 into project-chip:master Aug 22, 2022
@hsusid hsusid deleted the cyw30739-kvs-audit-fix branch August 23, 2022 01:32
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@hsusid @isiu-apple
[Infineon] Fix CYW30739 KVS to pass the storage API audit. (project-c…
bab3a45 
…hip#21995)

* Support key length upto PersistentStorageDelegate::kKeyLengthMax.
* _Get and _Put methods can handle zero-size data correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infineon] CYW30739 platform cannot pass the storage audit
4 participants
@hsusid @tcarmelveilleux @jmartinez-silabs @andy31415