-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix android dns-sd subtype error, and fix manualcode code pair search… #15009
fix android dns-sd subtype error, and fix manualcode code pair search… #15009
Conversation
32186b7
to
7e53c44
Compare
PR #15009: Size comparison from 56634bf to 7e53c44 Full report (6 builds for cyw30739, k32w, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This subtype format is not spec compliant and won't work with spec compliant commissioners. The fact that you cannot advertise subtypes for Android using NsdManager should not make it so that you cannot commission. If there is a fundamental.issue with the spec, let's discuss rather than make a format that concatenates subtypes in a way that is actually just one subtype
In fact, if we set type like "_matterc._udp,_S15", mDNSResponder will consider _S15 as a subtype. |
src/platform/android/java/chip/platform/NsdManagerServiceResolver.java
Outdated
Show resolved
Hide resolved
1b2cb08
to
fd1591a
Compare
PR #15009: Size comparison from a35b95a to fd1591a Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
fd1591a
to
5cb6c67
Compare
PR #15009: Size comparison from 3828308 to 5cb6c67 Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
5cb6c67
to
aa43b2f
Compare
PR #15009: Size comparison from d671a52 to aa43b2f Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
aa43b2f
to
70d7bad
Compare
PR #15009: Size comparison from 6103a69 to 70d7bad Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
project-chip#15009) * fix android dns-sd subtype error, and fix manualcode code pair search issue * fix restyled-io and ci errors * using append instead of + * added comment about this PR * fix restyled-io and ci errors * fix typos
Problem
Change overview
Testing