Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MF not work on Android #14944

Closed
xylophone21 opened this issue Feb 9, 2022 · 1 comment
Closed

MF not work on Android #14944

xylophone21 opened this issue Feb 9, 2022 · 1 comment
Labels
android commissioning Involves placing devices on the network, initial setup tv TV-related features

Comments

@xylophone21
Copy link
Collaborator

Problem

  • expected behavior
    • on android tv DUT
    • chip-tool pairing open-commissioning-window
    • chip-tool pairing manualcode
    • paring success
  • actual behavior
    • paring failed

Proposed Solution

  1. when calling chip-tool pairing manualcode, The TV should be fond by SetUpCodePairer::StartDiscoverOverIP
  2. It will call DeviceCommissioner::DiscoverCommissionableNodes --> MinMdnsResolver::FindCommissionableNodes --> MinMdnsResolver::BrowseNodes --> MinMdnsResolver::SendQuery, which will use subType to find the TV
  3. But on android TV, NsdManagerServiceResolver.java::publish, the subTypes is not used because there is no such support in android NSD_SERVICE
  4. Solutions
    1 Using both subtype and TxT in MinMdnsResolver to find TV
    2 Find some app layer DNS sd impl on Android TV

Which one do you think is better?
@lazarkov lazarkov added android commissioning Involves placing devices on the network, initial setup tv TV-related features labels Feb 9, 2022
@xylophone21 xylophone21 mentioned this issue Feb 10, 2022
Merged
@bzbarsky-apple
Copy link
Contributor

Fixed by #15009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android commissioning Involves placing devices on the network, initial setup tv TV-related features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xylophone21 @lazarkov @bzbarsky-apple