-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NsdService error due to subtypes on Android 14 #30830
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharadb-amazon
requested review from
xylophone21,
tcarmelveilleux and
chrisdecenzo
December 5, 2023 18:46
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
December 5, 2023 18:51
pullapprove
bot
requested review from
mkardous-silabs,
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
saurabhst,
selissia,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
December 5, 2023 18:51
PR #30830: Size comparison from 406ed8d to 4a194b4 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
chrisdecenzo
approved these changes
Dec 5, 2023
sharadb-amazon
force-pushed
the
nsderr-20231205
branch
from
December 5, 2023 20:02
4a194b4
to
4d92419
Compare
PR #30830: Size comparison from ca23c8a to 4d92419 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Dec 6, 2023
Looks like somebody submitted a fix for the original problem in AOSP: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2867134 Closing this PR as not required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30827
Problem
On Android 14, the Matter SDK throws an error when trying to register a DNS-SD service with sub-types (such as
_matterc._udp,_V65521,_T41,_S15,_L3840,_CM
). See error log below:See steps to repro in the issue linked above
Change summary
This change removes the addition of subtypes to the service type registered via the NsdManagerServiceResolver on Android, which was making use of an undocumented feature of the Android NsdManager. This feature is not supported anymore, as tested on Android 14.
Also see issue raised on Google's issue tracker to request support be added to publish subtypes: https://issuetracker.google.com/u/3/issues/314256875
Testing
Tested with the Android tv-casting-app commissioning against a Linux tv-app instance.