Skip to content

Commit

Permalink
New op creds yaml test (#28786)
Browse files Browse the repository at this point in the history
* Adding new ciTest Test_TC_OPCREDS_3_7.yaml

* Edit to new ciTest Test_TC_OPCREDS_3_7.yaml

* Fixed formatting issues in Test_TC_OPCREDS_3_7.yaml and added yaml to _GetChipReplUnsupportedTests

* Fixed failing steps on Test_TC_OPCREDS_3_7.yaml

* Added Test_TC_OPCREDS_3_7 to DFT CI Tests disabled list

* Update examples/darwin-framework-tool/templates/tests/ciTests.json

Co-authored-by: Boris Zbarsky <[email protected]>

* Update src/app/tests/suites/certification/Test_TC_OPCREDS_3_7.yaml

Co-authored-by: Boris Zbarsky <[email protected]>

* Updated reasoning for disabled step for src/app/tests/suites/certification/Test_TC_OPCREDS_3_7.yaml

* Addressing changes made to the test plan in CHIP-Specifications/chip-test-plans/pull/3398 for Step 6 and Step 12

* Provided justification for Step 9/10 being disabled

* cleanup verification step comments based on Test Plan PR

* Apply suggestions from code review

Co-authored-by: Boris Zbarsky <[email protected]>

* Added WaitForCommissionee to Step 10 to guarantee we do CASE

* Applied restyled patch

---------

Co-authored-by: Boris Zbarsky <[email protected]>
  • Loading branch information
2 people authored and pull[bot] committed Jan 29, 2024
1 parent 65103a2 commit 1398882
Show file tree
Hide file tree
Showing 4 changed files with 224 additions and 143 deletions.
2 changes: 2 additions & 0 deletions examples/darwin-framework-tool/templates/tests/ciTests.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
"Test_TC_ACL_2_8",
"Test_TC_ACL_2_9",
"Test_TC_ACL_2_10",
"Disabled due to GetCommissionerRootCertificate command not being supported",
"Test_TC_OPCREDS_3_7",
"DL_LockUnlock",
"Disabled due to Events verification not supported",
"Test_TC_BINFO_2_2",
Expand Down
1 change: 1 addition & 0 deletions scripts/tests/chiptest/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ def _GetChipReplUnsupportedTests() -> Set[str]:
"""Tests that fail in chip-repl for some reason"""
return {
"Test_AddNewFabricFromExistingFabric.yaml", # chip-repl does not support GetCommissionerRootCertificate and IssueNocChain command
"Test_TC_OPCREDS_3_7.yaml", # chip-repl does not support GetCommissionerRootCertificate and IssueNocChain command
"TestEqualities.yaml", # chip-repl does not support pseudo-cluster commands that return a value
"TestExampleCluster.yaml", # chip-repl does not load custom pseudo clusters
"TestAttributesById.yaml", # chip-repl does not support AnyCommands (06/06/2023)
Expand Down
Loading

0 comments on commit 1398882

Please sign in to comment.