Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INFRA] prod - Bump mxgraph from 4.1.0 to 4.2.2 #1784

Closed
wants to merge 3 commits into from
Closed

[INFRA] prod - Bump mxgraph from 4.1.0 to 4.2.2 #1784

wants to merge 3 commits into from

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Jan 31, 2022 •
edited
Loading

WIP - to much regression

closes #321
closes #919

Current status

@tbouffard tbouffard added dependencies Pull requests that update a dependency (dev or runtime) javascript Pull requests that update Javascript code WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft labels Jan 31, 2022
@github-actions
Copy link

github-actions bot commented Jan 31, 2022 •
edited
Loading

😭 Deploy PR Preview 520501c failed. Build logs

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Jan 31, 2022 •
edited
Loading

😭 Deploy PR Preview 520501c failed. Build logs

🤖 By surge-preview

@tbouffard tbouffard mentioned this pull request Jan 31, 2022
Merged
@tbouffard tbouffard force-pushed the 919-bump_mxgraph_to_4.2.2 branch from b85fdfe to 2074eaf Compare February 6, 2022 14:36
@tbouffard tbouffard force-pushed the 919-bump_mxgraph_to_4.2.2 branch from 2074eaf to 520501c Compare February 7, 2022 14:03
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tbouffard tbouffard mentioned this pull request Feb 15, 2022
Merged
@tbouffard
Copy link
Member Author

tbouffard commented Mar 11, 2022 •
edited
Loading

Unwanted side effects

There are issues with the Segment Connector (see #994 (comment)) introduced in [email protected]. We already saw such issue in #1363.
In the following, the diagrams at the bottom of the images are rendered with the newest mxgraph version

wrong segment on the right extra segment within shape inverted arrow within the shape
flows message 02 labels and complex paths-diff flows message 03 waypoints 01 none-diff flows message 03 waypoints 02 inside-diff

@tbouffard
Copy link
Member Author

tbouffard commented Mar 16, 2022 •
edited
Loading

Too much side effects.
As explain in #295 (comment), we will remove the Segment Connector prior bumping mxgraph. #1863 has shown the removal will work also with [email protected].
So closing.

@tbouffard tbouffard closed this Mar 16, 2022
@tbouffard tbouffard deleted the 919-bump_mxgraph_to_4.2.2 branch March 18, 2022 10:10
@tbouffard tbouffard mentioned this pull request Mar 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency (dev or runtime) javascript Pull requests that update Javascript code WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[INFRA] Bump mxgraph to 4.2.2 [FEAT] Improve label position accuracy
1 participant
@tbouffard