Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] prod - Bump mxgraph from 4.1.0 to 4.2.2 #1872

Merged
merged 25 commits into from
Mar 22, 2022

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Mar 18, 2022

Finally, it makes the bump happen as there are no more side effects since we removed the Segment Connector configuration.
The new version of mxGraph slightly improves the position of the labels by moving them to the left which is more accurate regarding the values in the BPMN diagram.

The custom mxGraph extensions have been migrated

Tests and screenshots

  • All screenshots have been done with Chromium 100.0.4863.0 (Playwright 1.19.2) on Ubuntu 20.04.4 LTS.
  • The thresholds configuration has been adapted
    • most of the thresholds are now using a syntax closed to the percentage value i.e 0.02 / 100 instead of 0.0002. This improves readability for comparison with the actual percentage value found in the test report. This will also easily switch to the direct percentage value in the future (direct usage of 0.02 in the previous example)
    • some thresholds have been fixed. They were previously 100 times larger than the right value (they were missing the 100 divisor). For instance, in bpmn.rendering.test.ts, the Firefox 'labels.01.general' threshold on windows was 13.53, it is now fixed to 13.42 / 100. These errors were recently introduced when removing the 'no orthogonal segments' (refs [FIX] Do not force usage of orthogonal edge segments #1868).

Notes

This PR is a new attempt after #502, #547, #1784 (commits of 1784 have been reused here)
closes #321
closes #919

@tbouffard tbouffard added dependencies Pull requests that update a dependency (dev or runtime) WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft javascript Pull requests that update Javascript code labels Mar 18, 2022
@github-actions
Copy link

github-actions bot commented Mar 18, 2022

♻️ PR Preview 2e2f280 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Mar 18, 2022

♻️ PR Preview 2e2f280 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@tbouffard tbouffard removed the WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft label Mar 21, 2022
@tbouffard tbouffard marked this pull request as ready for review March 21, 2022 05:47
…or reconfiguration

recreate screenshots that involve labels
…sholds for reconfiguration

recreate screenshots that involve labels
@csouchet csouchet force-pushed the 919-bump_mxgraph_to_4.2.2 branch from 9384cc7 to 2e2f280 Compare March 22, 2022 13:55
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@csouchet csouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job for the upgrading of mxGraph 🎉 👍🏻

@tbouffard tbouffard merged commit b310fb0 into master Mar 22, 2022
@tbouffard tbouffard deleted the 919-bump_mxgraph_to_4.2.2 branch March 22, 2022 14:55
Copy link

Pull request title linting 🚨

In order to merge this pull request, the title of the pull request should be prefixed by one of the available types.

Available types:

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

Examples
feat(grpc): add new endpoint
refactor: combine class A and class B
ci: update pull request linter
style: change format of strings

💁 For more examples, visit https://www.conventionalcommits.org/en/v1.0.0/#examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency (dev or runtime) javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INFRA] Bump mxgraph to 4.2.2 [FEAT] Improve label position accuracy
2 participants