-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INFRA] prod - Bump mxgraph from 4.1.0 to 4.2.2 #1872
Conversation
♻️ PR Preview 2e2f280 has been successfully destroyed since this PR has been closed. 🤖 By surge-preview |
♻️ PR Preview 2e2f280 has been successfully destroyed since this PR has been closed. 🤖 By surge-preview |
…or reconfiguration recreate screenshots that involve labels
…sholds for reconfiguration recreate screenshots that involve labels
9384cc7
to
2e2f280
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good job for the upgrading of mxGraph 🎉 👍🏻
Pull request title linting 🚨In order to merge this pull request, the title of the pull request should be prefixed by one of the available types. Available types:
Examples
💁 For more examples, visit https://www.conventionalcommits.org/en/v1.0.0/#examples. |
Finally, it makes the bump happen as there are no more side effects since we removed the
Segment Connector
configuration.The new version of mxGraph slightly improves the position of the labels by moving them to the left which is more accurate regarding the values in the BPMN diagram.
The custom mxGraph extensions have been migrated
ShapeConfigurator
MxGraphCustomOverlay
our implementation is based onmxCellOverlay.prototype.getBounds
: no change in https://github.com/jgraph/mxgraph/blob/v4.2.2/javascript/src/js/view/mxCellOverlay.js since v3.4.0Tests and screenshots
0.02 / 100
instead of0.0002
. This improves readability for comparison with the actual percentage value found in the test report. This will also easily switch to the direct percentage value in the future (direct usage of0.02
in the previous example)bpmn.rendering.test.ts
, the Firefox 'labels.01.general' threshold on windows was 13.53, it is now fixed to 13.42 / 100. These errors were recently introduced when removing the 'no orthogonal segments' (refs [FIX] Do not force usage of orthogonal edge segments #1868).Notes
This PR is a new attempt after #502, #547, #1784 (commits of 1784 have been reused here)
closes #321
closes #919