Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Improve label position accuracy #321

Closed
tbouffard opened this issue Jun 17, 2020 · 2 comments · Fixed by #1872
Closed

[FEAT] Improve label position accuracy #321

tbouffard opened this issue Jun 17, 2020 · 2 comments · Fixed by #1872
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request mxgraph integration Something involving mxGraph (be aware of EOL)
Milestone
0.23.1

Comments

@tbouffard
Copy link
Member

The label seem slightly translated to the bottom-right direction, see #299 (comment) for shape label.
@tbouffard tbouffard added enhancement New feature or request BPMN rendering Something about the way the lib is rendering BPMN elements labels Jun 17, 2020
@tbouffard tbouffard mentioned this issue Jun 17, 2020
Merged
@tbouffard tbouffard added this to the 0.1.x milestone Jun 17, 2020
@NathalieC NathalieC removed this from the 0.1.x milestone Jun 23, 2020
@tbouffard
Copy link
Member Author

tbouffard commented Jun 23, 2020 •
edited
Loading

mxGraph upgrade to 4.1.1+ may improve position accuracy.
See process-analytics/mxgraph2@49f1e82 introduced in 4.1.1: "Fixes inconsistent text rendering, center alignment "

@tbouffard tbouffard added this to the BPMN rendering improvements milestone Aug 3, 2020
@tbouffard
Copy link
Member Author

tbouffard commented Sep 4, 2020 •
edited
Loading

It has been confirmed that the text is moved to the left when upgrading to 4.1.1, see

@tbouffard tbouffard mentioned this issue Nov 30, 2020
Closed
2 tasks
@tbouffard tbouffard added the mxgraph integration Something involving mxGraph (be aware of EOL) label Nov 30, 2020
@tbouffard tbouffard mentioned this issue Jan 31, 2022
Closed
@tbouffard tbouffard mentioned this issue Mar 18, 2022
Merged
@csouchet csouchet modified the milestones: 0.23.0, 0.24.0 Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request mxgraph integration Something involving mxGraph (be aware of EOL)
Projects
None yet
Milestone
0.23.1
3 participants
@csouchet @NathalieC @tbouffard