Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Investigate fix for edge start/end positions when zooming #1363

Closed

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Jun 14, 2021

refs #994

Try to port the draw.io Segment Connector fixes. Not working.
The Segment Connector is responsible of the orthogonal segments (#295). When using the default configuration (i.e no connector via STYLE_EDGE), there is no issue, so I suggest we investigate time to be able to stop using the Segment Connector (#295) instead of trying to fix mxgraph.

With file 01

mxgraph 4.1.0 (currently used) with fix attempt

file01_mxgraph_4 1 0_with_fix_attempt

mxgraph 4.2.2 standard

file01_mxgraph_4 2 2_std

mxgraph 4.2.2 with fix attempt

file01_mxgraph_4 2 2_with_fix_attempt

With file 02

mxgraph 4.1.0 (currently used) with fix attempt
file02_mxgraph_4 1 0_with_fix_attempt

mxgraph 4.2.2 standard
file02_mxgraph_4 2 2_std

mxgraph 4.2.2 with fix attempt
file02_mxgraph_4 2 2_with_fix_attempt

@tbouffard tbouffard added the poc 💫 Experimentation to discuss about future implementation. Not intended to be merged label Jun 14, 2021
@github-actions
Copy link

github-actions bot commented Jun 14, 2021

🎊 PR Preview bab4589 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-1363.surge.sh

🕐 Build time: 26.949s

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Jun 14, 2021

🎊 PR Preview bab4589 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-1363.surge.sh

🕐 Build time: 51.61s

🤖 By surge-preview

@tbouffard tbouffard changed the title [POC] Investigate [POC] Investigate fix for edge start/end positions when zooming Jun 14, 2021
@tbouffard
Copy link
Member Author

Poc completed, so closing.

@tbouffard tbouffard closed this Jul 6, 2021
@tbouffard tbouffard deleted the poc/994_fix_scaling_issue_in_mxgraph_EdgeConnector branch July 6, 2021 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
poc 💫 Experimentation to discuss about future implementation. Not intended to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant