Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Partial fix for middle position for overlays on edge #1373

Closed
wants to merge 2 commits into from

Conversation

aibcmars
Copy link
Contributor

@aibcmars aibcmars commented Jun 17, 2021

needs further development (check TODO:)

covers #1236

@aibcmars aibcmars added the poc 💫 Experimentation to discuss about future implementation. Not intended to be merged label Jun 17, 2021
@github-actions
Copy link

github-actions bot commented Jun 17, 2021

🎊 PR Preview 386e857 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-1373.surge.sh

🕐 Build time: 46.963s

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Jun 17, 2021

🎊 PR Preview 386e857 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-1373.surge.sh

🕐 Build time: 26.025s

🤖 By surge-preview

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@tbouffard tbouffard marked this pull request as draft June 21, 2021 16:10
@tbouffard
Copy link
Member

tbouffard commented Jun 21, 2021

ℹ️ This Pull Request is not intended to be merged. It is for investigation on #1236.
As for #1363, the root cause is due to issues in the the mxgraph Segment Connector code (orthogonal segments, #295). See #1236 (comment)

@tbouffard
Copy link
Member

Poc completed, so closing

@tbouffard tbouffard closed this Jul 6, 2021
@tbouffard tbouffard deleted the poc-fix_position_of_middle_overlay branch July 6, 2021 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
poc 💫 Experimentation to discuss about future implementation. Not intended to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants