Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] The 'middle' position for the overlay is not the same after zoom than after fit #1236

Closed
csouchet opened this issue Apr 15, 2021 · 2 comments · Fixed by #1868
Closed

[BUG] The 'middle' position for the overlay is not the same after zoom than after fit #1236

csouchet opened this issue Apr 15, 2021 · 2 comments · Fixed by #1868
Labels
BPMN diagram overlays Overlays: positioning, shapes, functionality bug Something isn't working
Milestone
0.23.0

Comments

@csouchet
Copy link
Member

csouchet commented Apr 15, 2021 •
edited by tbouffard
Loading

Add overlay on middle of a edge after zoom

Enregistrement.de.l.ecran.2021-04-14.a.19.19.27.mov

Add overlay on middle of a edge after fit

Enregistrement.de.l.ecran.2021-04-14.a.19.19.10.mov

Edge overlay middle position changing on zoom

Detected during development
See #1207 (comment) or #1207 (comment)

PR-1207_overlays_on_msg_flow_middle_depends_on_scaling

From the example repository

edge_overlays_middle_position_changing_on_zoom
@csouchet csouchet added bug Something isn't working BPMN diagram usability Something about the way we can interact with BPMN diagrams labels Apr 15, 2021
@csouchet
Copy link
Member Author

csouchet commented Apr 15, 2021 •
edited by tbouffard
Loading

Seems close to #994

@tbouffard tbouffard mentioned this issue Apr 15, 2021
Open
@aibcmars aibcmars added the BPMN diagram overlays Overlays: positioning, shapes, functionality label May 20, 2021
@aibcmars aibcmars removed the BPMN diagram usability Something about the way we can interact with BPMN diagrams label May 25, 2021
@tbouffard
Copy link
Member

tbouffard commented Jun 14, 2021 •
edited
Loading

Disabling the orthogonal segments i.e don't use Segment Connector (#295) fix the issue. The root cause is due to a mxGraph bug that wrongly modifies the waypoints list, see #994 (comment)

With the overlays/overlays.edges.message.flows.complex.paths.bpmn diagram used in e2e tests

overlays_no_orthogonal_segments

Additional investigations
A poc has also been done to try to recompute the middle position: #1373.
However, we should rely on mxgraph points for simplificity. So I would prefer we find the right mxGraph configuration.

@tbouffard tbouffard mentioned this issue Jun 21, 2021
Closed
@tbouffard tbouffard mentioned this issue Aug 24, 2021
Closed
@tbouffard tbouffard mentioned this issue Sep 1, 2021
Merged
This was referenced Mar 14, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BPMN diagram overlays Overlays: positioning, shapes, functionality bug Something isn't working
Projects
None yet
Milestone
0.23.0
Development

Successfully merging a pull request may close this issue.

[FIX] Do not force usage of orthogonal edge segments process-analytics/bpmn-visualization-js
3 participants
@csouchet @tbouffard @aibcmars