Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Restore the experimental pools/subprocess live collapsing #1871

Open
tbouffard opened this issue Mar 18, 2022 · 0 comments
Open

[FEAT] Restore the experimental pools/subprocess live collapsing #1871

tbouffard opened this issue Mar 18, 2022 · 0 comments
Labels
BPMN diagram usability Something about the way we can interact with BPMN diagrams enhancement New feature or request

Comments

@tbouffard
Copy link
Member

tbouffard commented Mar 18, 2022

Is your feature request related to a problem? Please describe.
After the merge of #1868, there is no more usage of the Segment Connector. This setting was recomputing the whole edge path. It was able to set the terminal waypoints to the collapsed pools when the edge was targeting a inner element of the pool (hidden when the pool is collapsed).
There is no more waypoints' computation with the new implementation: in this case, we see a dangling edge. The edge
terminal waypoint are inside the pool.

You can find more details in

Describe the solution you'd like
Understand how the mxgraph Segment Connector implementation was working and how it recomputes the whole waypoints.
Try to replicate it to support the use case.
The implementation will probably use the "terminal port", see https://jgraph.github.io/mxgraph/docs/js-api/files/util/mxConstants-js.html#mxConstants.STYLE_SOURCE_PORT (and target port).

Reminder:

Additional context
Screenshots of the collapsed pools used in visual tests with the new implementation introduced by #1868.

collapsing pools on the left of the diagram collapsing pools on the right of the diagram
pools-collapse-Participant_1-diff-02-actual pools-collapse-Participant_3-diff-02-actual
pools-collapse-Participant_2-diff-02-actual pools-collapse-Participant_4-diff-02-actual
@tbouffard tbouffard added enhancement New feature or request BPMN diagram usability Something about the way we can interact with BPMN diagrams labels Mar 18, 2022
@tbouffard tbouffard changed the title [FEAT] Restore the experimental [FEAT] Restore the experimental pools/subprocess live collapsing Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN diagram usability Something about the way we can interact with BPMN diagrams enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant