[TEST] Add visual tests for edges targeting collapsed elements #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes - add diagrams for expanded/collapsed pools and subprocesses - HTML page: manage collapse element query parameter - added tests: test the diagram rendering with and without collapsed elements Note that collapsing elements is not officially supported and is managed with mxGraph custom code. We demonstrate it in the examples, so the new tests ensure the sequence and message flows are rendered correctly in this case.
tbouffard
added
the
chore
|
♻️ PR Preview 3e12797 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
Kudos, SonarCloud Quality Gate passed!
|
csouchet
approved these changes
Mar 16, 2022
This was referenced Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note that collapsing elements is not officially supported and is managed with mxGraph custom code.
We demonstrate it in the examples, so the new tests ensure the sequence and message flows are rendered correctly. The new tests should avoid finding a problem in the examples repository after a new version is released.
covers #295
Notes
These non regression tests are added based on the experience collected in #1863. There is a potential regression, so let's introduce tests before a silent regression happens!
What we see on the boundary events on the collapsed sub-process is what is expected from the implementation point of view.
The events are attached to the subprocess. When it is collapsed, mxGraph hides the boundary events as all other inner elements (parent-child relation between the subprocess and its boundary events).
From the BPMN point of view, the boundary events should be displayed. As we are not officially supporting the collapsed elements, no change will be introduced to fix the current behavior. The test are here to describe what we see now.
Note: we correctly support the rendering of boundary events attached to declared (in the BPMN source) collapsed-sub-process (see #821)