Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Display boundary events of collapsed sub-process #821

Merged
merged 2 commits into from
Oct 23, 2020

Conversation

tbouffard
Copy link
Member

Reproduce the issue with

  • model e2e test
  • visual test (including transaction and adhoc sub process)

closes #819

A.3.0 prior the fix

boundary_events_collapsed_subprocess_bpmn-visualization@0 5 0

A.3.0 with the fix

A 3 0_with_819_fix

Reproduce the issue with
- model e2e test
- visual test (including transaction and adhoc sub process)
@tbouffard tbouffard added bug Something isn't working BPMN rendering Something about the way the lib is rendering BPMN elements labels Oct 23, 2020
@@ -596,6 +596,13 @@ describe('mxGraph model', () => {
verticalAlign: 'bottom',
});

// Elements of collapsed Sub Process
expect('message_boundary_event_attached_to_collapsed_embedded_sub_process_id').toBeBoundaryEvent({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@csouchet csouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@csouchet csouchet merged commit 0a49ce0 into master Oct 23, 2020
@csouchet csouchet deleted the 819-display_boundary_events_of_collapsed_subprocess branch October 23, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Boundary events of collapsed sub-process aren't displayed
2 participants