Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Elements of an expanded Call Activity are not linked to the Call Activity #2036

Closed
5 tasks done
csouchet opened this issue Jun 9, 2022 · 0 comments · Fixed by #2140
Closed
5 tasks done

[BUG] Elements of an expanded Call Activity are not linked to the Call Activity #2036

csouchet opened this issue Jun 9, 2022 · 0 comments · Fixed by #2140
Assignees
Labels
BPMN support Something about the BPMN specification that the lib is already supporting or will support bug Something isn't working
Milestone

Comments

@csouchet
Copy link
Member

csouchet commented Jun 9, 2022

For such elements, the parent property is not set to the Call Activity.

If we filter a BPMN source to display only the content of a specific Pool (see #2063), the content of an expanded Call Activity is not displayed because we don't find the parent relationship like in this example involving the miwg-test-suite B.2.0 diagram.
This also prevents from collapsing call activities (we would like to restore this experimental feature #1871)

image

This is due to the fact that, at no time, the information from the called Process is stored: https://github.com/process-analytics/bpmn-visualization-js/pull/2020/files#diff-a3f4d22ee90476febc6e7329a9d846e235d02b8e5e49b9c3fdc9fe92c1937b38R151

To do that we need to

  • store the converted CallActivity and its calledElement in a map
  • store the converted elements of a Process and the Process id in a map
  • when all the processes are converted, assign the CallActivity as parent of all the elements of the Process corresponding to its calledElement.
  • review unit and integration model tests to ensure we check the inner elements of the expanded CallActivity
  • update/add e2e visual tests to check that inner elements are displayed (do something similar to what we have for expanded sub-process)
@csouchet csouchet added the bug Something isn't working label Jun 9, 2022
@csouchet csouchet added this to the 0.25.0 milestone Jun 9, 2022
@csouchet csouchet moved this to Todo in Roadmap 2023 Jun 9, 2022
@csouchet csouchet removed this from Roadmap 2023 Jun 9, 2022
@csouchet csouchet modified the milestones: 0.25.0, Next Jun 13, 2022
@tbouffard tbouffard added the BPMN support Something about the BPMN specification that the lib is already supporting or will support label Jun 17, 2022
@tbouffard tbouffard changed the title [BUG] Link the elements of a Process called by an expanded Call Activity [BUG] Elements of an expanded Call Activity are not linked to the Call Activity Jun 20, 2022
@csouchet csouchet modified the milestones: 0.25.0, 0.25.1 Jun 27, 2022
@oanesini oanesini modified the milestones: 0.25.1, 0.25.2 Jul 11, 2022
@csouchet csouchet modified the milestones: 0.25.2, 0.25.3 Jul 25, 2022
@csouchet csouchet self-assigned this Jul 26, 2022
@csouchet csouchet modified the milestones: 0.26.0, 0.26.1 Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN support Something about the BPMN specification that the lib is already supporting or will support bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants