[FEAT] Disable pool collapsing #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upcoming bpmn-visualization version changes the edge rendering. There is no more usage of the Segment Connector. This setting was recomputing the whole edge path. It was able to set the terminal waypoints to the collapsed pools when the edge was targeting a inner element of the pool (hidden when the pool is collapsed). There is no more waypoints' computation with the new implementation: in this case, we see a dangling edge. The edge terminal waypoint are inside the pool.
tbouffard
commented
Mar 18, 2022
examples/custom-behavior/select-elements-by-bpmn-kind/index.html
Outdated
Show resolved
Hide resolved
csouchet
reviewed
Mar 18, 2022
| @@ -116,9 +116,11 @@ <h2>Select elements by BPMN kind</h2> | |||
| <div class="radio"> | |||
| <label><input type="radio" name="poolSelectionMethod" value="hide" checked> Hide others</label> | |||
| </div> | |||
| <!-- Disable collapsing: see https://github.com/process-analytics/bpmn-visualization-examples/pull/306 | |||
There was a problem hiding this comment.
Is it an omission ?
If not, no need a single radio button for hide 🙂
There was a problem hiding this comment.
I wanted to limit the modifications especially in the js code.
Here is what we see for now
csouchet
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upcoming bpmn-visualization version changes the edge rendering. There is no more usage of the Segment Connector.
This setting was recomputing the whole edge path. It was able to set the terminal waypoints to the collapsed pools when
the edge was targeting a inner element of the pool (hidden when the pool is collapsed).
There is no more waypoints' computation with the new implementation: in this case, we see a dangling edge. The edge
terminal waypoint are inside the pool.
See #306 and process-analytics/bpmn-visualization-js#1863 (comment)
Live environment of examples
https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/feat/disable_pools_collapsing/examples/index.html